From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756542AbaGDKKF (ORCPT ); Fri, 4 Jul 2014 06:10:05 -0400 Received: from zabrina.hetzner-de.towertech.it ([178.63.16.19]:50042 "EHLO zabrina.hetzner-de.towertech.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbaGDKKD (ORCPT ); Fri, 4 Jul 2014 06:10:03 -0400 Date: Fri, 4 Jul 2014 12:10:00 +0200 From: Alessandro Zummo To: Hyogi Gim Cc: John Stultz , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [rtc-linux] [PATCH] drivers/rtc/interface.c: check the error after __rtc_read_time() Message-ID: <20140704121000.608901c9@linux.lan.towertech.it> In-Reply-To: <1404436946-28354-1-git-send-email-hyogi.gim@lge.com> References: <1404436946-28354-1-git-send-email-hyogi.gim@lge.com> Organization: Tower Technologies MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Jul 2014 10:22:26 +0900 Hyogi Gim wrote: > In __rtc_set_alarm(), the error after __rtc_read_time() is not checked. > If rtc device fail to read time, we cannot guarantee the following process. > > Add the verification code for returned __rtc_read_time() error. > > Signed-off-by: Hyogi Gim Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it