Re: [PATCH 3.14 00/59] 3.14.11-stable review

Satoru Takeuchi
2014-07-05T09:21:14Z

Hi Greg,

Add Takashi Iwai to this thread.

At Sat, 05 Jul 2014 16:00:41 +0900,
Satoru Takeuchi wrote:
>
> At Fri, 04 Jul 2014 22:45:42 -0700,
> Guenter Roeck wrote:
> >
> > On 07/04/2014 03:18 PM, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 3.14.11 release.
> > > There are 59 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Sun Jul 6 22:15:27 UTC 2014.
> > > Anything received after that time might be too late.
> > >
> >
> > Build results:
> > total: 144 pass: 130 skipped: 4 fail: 10
> > Failed builds:
> > alpha:allmodconfig
> > i386:allyesconfig
> > i386:allmodconfig
> > powerpc:allmodconfig (binutils 2.23)
> > powerpc:allmodconfig (binutils 2.24)
> > sparc64:allmodconfig
> > unicore32:defconfig
> > x86_64:allyesconfig
> > x86_64:allmodconfig
> > xtensa:allmodconfig
> >
> > Qemu test for x86 failed.
> >
> > Build error is the same as seen with 3.14.
> >
> > sound/pci/hda/patch_sigmatel.c: In function 'stac92hd95_fixup_hp_led':
> > sound/pci/hda/patch_sigmatel.c:4143:3: error: implicit declaration of function 'codec_dbg' [-Werror=implicit-function-declaration]
>
> This kernel failed to build with the following error. Probably the root
> cause is the same as Guenter. I'm now bisecting to find the problematic
> patch...

The following patch caused the boot failure of both this kernel and 3.10.47-rc1.

alsa-hda-adjust-speaker-hpf-and-add-led-support-for-hp-spectre-13.patch:
===============================================================================
>From 8b3dfdaf0c25a584cb31d04d2574115cf2d422ab Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Tue, 24 Jun 2014 13:55:25 +0200
Subject: ALSA: hda - Adjust speaker HPF and add LED support for HP Spectre 13

From: Takashi Iwai <tiwai@suse.de>

commit 8b3dfdaf0c25a584cb31d04d2574115cf2d422ab upstream.

HP Spectre 13 has the IDT 92HD95 codec, and BIOS seems to set the
default high-pass filter in some "safer" range, which results in the
very soft tone from the built-in speakers in contrast to Windows.
Also, the mute LED control is missing, since 92HD95 codec still has no
HP-specific fixups for GPIO setups.

This patch adds these missing features: the HPF is adjusted by the
vendor-specific verb, and the LED is set up from a DMI string (but
with the default polarity = 0 assumption due to the incomplete BIOS on
the given machine).

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=74841
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
...
===============================================================================

This patch uses codec_dbg(), however, this macro is intrdocuded by the
following patch and it's not applied to these stable-tree yet.

===============================================================================
ommit 4e76a8833fac8dc1735aa5be7d1b3c92c65e209e
Author: Takashi Iwai <tiwai@suse.de>
Date: Tue Feb 25 12:21:03 2014 +0100

ALSA: hda - Replace with standard printk

Use dev_err() and co for messages from HD-audio controller and codec
drivers. The codec drivers are mostly bound with codec objects, so
some helper macros, codec_err(), codec_info(), etc, are provided.
They merely wrap the corresponding dev_xxx().

There are a few places still calling snd_printk() and its variants
as they are called without the codec or device context.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
...
===============================================================================

Unfortunately I failed to apply this patch to 3.14.11-rc1 with the following
error log.

===============================================================================
$ git apply ~/src/test-linux-stable/extra_patch.txt
error: patch failed: sound/pci/hda/hda_intel.c:897
error: sound/pci/hda/hda_intel.c: patch does not apply
error: sound/pci/hda/hda_sysfs.c: No such file or directory
===============================================================================

I'm not sure whether we should drop this patch or should apply extra patches
to remove this build failure. Any idea?

Thanks,
Satoru

>
> ===============================================================================
> ...
> home/sat/src/test-linux-stable/linux-stable/sound/pci/hda/patch_sigmatel.c:4143:3: error: implicit declaration of function ‘codec_dbg’ [-Werror=implicit-function-declaration]
> codec_dbg(codec, "mute LED gpio %d polarity %d\n",
> ^
> LD [M] sound/pci/echoaudio/snd-indigoio.o
> LD [M] sound/pci/echoaudio/snd-indigodj.o
> LD [M] sound/pci/echoaudio/snd-indigoiox.o
> LD [M] sound/pci/echoaudio/snd-indigodjx.o
> CC [M] sound/pci/hda/patch_via.o
> LD sound/pci/ice1712/built-in.o
> CC [M] sound/pci/ice1712/ice1712.o
> cc1: some warnings being treated as errors
> /home/sat/src/test-linux-stable/linux-stable/scripts/Makefile.build:308: recipe for target 'sound/pci/hda/patch_sigmatel.o' failed
> make[4]: *** [sound/pci/hda/patch_sigmatel.o] Error 1
> ...
> CC drivers/iommu/irq_remapping.o
> /home/sat/src/test-linux-stable/linux-stable/scripts/Makefile.build:455: recipe for target 'sound/pci/hda' failed
> make[3]: *** [sound/pci/hda] Error 2
> ...
> /home/sat/src/test-linux-stable/linux-stable/scripts/Makefile.build:455: recipe for target 'sound/pci' failed
> make[2]: *** [sound/pci] Error 2
> /home/sat/src/test-linux-stable/linux-stable/Makefile:841: recipe for target 'sound' failed
> make[1]: *** [sound] Error 2
> ...
> Makefile:133: recipe for target 'sub-make' failed
> make: *** [sub-make] Error 2
> FAILED!
> CRITICAL FAILURE... failed build
> ...
> ===============================================================================
>
> - Test Cases:
> - Build this kernel.
> - Boot this kernel.
> - Build the latest mainline kernel with this kernel.
>
> - Test Tool:
> https://github.com/satoru-takeuchi/test-linux-stable
>
> - Test Result (kernel .config, ktest config and test log):
> http://satoru-takeuchi.org/test-linux-stable/results/<version>-<test datetime>.tar.xz
>
> - Build Environment:
> - OS: Debian Jessy x86_64
> - CPU: Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz x 4
> - memory: 8GB
>
> - Test Target Environment:
> - Debian Jessy x86_64 (KVM guest on the Build Environment)
> - # of vCPU: 2
> - memory: 2GB
>
> Thanks,
> Satoru
>
>
> >
> > Guenter
> >