From: Johan Hovold <johan@kernel.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Johan Hovold <jhovold@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/usb/serial/mos7840.c: remove unnecessary null test before kfree
Date: Mon, 7 Jul 2014 10:23:21 +0200 [thread overview]
Message-ID: <20140707082321.GA29098@localhost> (raw)
In-Reply-To: <1403959449-5986-1-git-send-email-fabf@skynet.be>
On Sat, Jun 28, 2014 at 02:44:09PM +0200, Fabian Frederick wrote:
> Cc: Johan Hovold <jhovold@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied, thanks.
Johan
> ---
> drivers/usb/serial/mos7840.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 393be56..3d88eef 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -1181,10 +1181,7 @@ static void mos7840_close(struct usb_serial_port *port)
> /* Freeing Write URBs */
> for (j = 0; j < NUM_URBS; ++j) {
> if (mos7840_port->write_urb_pool[j]) {
> - if (mos7840_port->write_urb_pool[j]->transfer_buffer)
> - kfree(mos7840_port->write_urb_pool[j]->
> - transfer_buffer);
> -
> + kfree(mos7840_port->write_urb_pool[j]->transfer_buffer);
> usb_free_urb(mos7840_port->write_urb_pool[j]);
> }
> }
prev parent reply other threads:[~2014-07-07 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 12:44 [PATCH 1/1] drivers/usb/serial/mos7840.c: remove unnecessary null test before kfree Fabian Frederick
2014-07-07 8:23 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707082321.GA29098@localhost \
--to=johan@kernel.org \
--cc=fabf@skynet.be \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).