From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/1] perf: Prevent race in PERF_SAMPLE_READ group format sample output
Date: Mon, 7 Jul 2014 13:43:46 +0200 [thread overview]
Message-ID: <20140707114346.GD19379@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140707102020.GA22764@krava.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Mon, Jul 07, 2014 at 12:20:20PM +0200, Jiri Olsa wrote:
> On Mon, Jul 07, 2014 at 11:04:28AM +0200, Peter Zijlstra wrote:
> > On Wed, Jun 25, 2014 at 08:44:35PM +0200, Jiri Olsa wrote:
> > > From: Jiri Olsa <jolsa@redhat.com>
> > >
> > > While iterating siblings in perf_output_read_group we could
> > > race with addition and removal of sibling in perf_group_attach
> > > and perf_group_detach respective.
> >
> > So why would anybody do this?
>
> the test program from 0/1 email hangs up my server
> but no standard reason AFAICS
>
> I've got soft lockup, sometimes ended up with unkillable perf process
> also few total server hangs
OK, so that's useful information to have in a Changelog ;-)
Not immediately obvious how that can happen though. I can see the output
getting scrambled.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-07-07 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 18:44 [PATCH 0/1] perf: Fix race in sample output Jiri Olsa
2014-06-25 18:44 ` [PATCH 1/1] perf: Prevent race in PERF_SAMPLE_READ group format " Jiri Olsa
2014-07-02 7:56 ` Jiri Olsa
2014-07-07 9:04 ` Peter Zijlstra
2014-07-07 10:20 ` Jiri Olsa
2014-07-07 11:43 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707114346.GD19379@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox