From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbaGGO7S (ORCPT ); Mon, 7 Jul 2014 10:59:18 -0400 Received: from mail-ie0-f171.google.com ([209.85.223.171]:36562 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753263AbaGGO7Q (ORCPT ); Mon, 7 Jul 2014 10:59:16 -0400 Date: Mon, 7 Jul 2014 15:59:10 +0100 From: Lee Jones To: Kishon Vijay Abraham I Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, sergei.shtylyov@cogentembedded.com, antoine.tenart@free-electrons.com, kgene.kim@samsung.com, maxime.ripard@free-electrons.com Subject: Re: [RFC PATCH 2/2] phy: core: the node pointer of PHY need not be the same as that of PHY provider Message-ID: <20140707145910.GK6407@lee--X1> References: <1404486474-28312-1-git-send-email-kishon@ti.com> <1404486474-28312-3-git-send-email-kishon@ti.com> <20140707131232.GI6407@lee--X1> <53BAAA19.9050106@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53BAAA19.9050106@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Jul 2014, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 07 July 2014 06:42 PM, Lee Jones wrote: > > On Fri, 04 Jul 2014, Kishon Vijay Abraham I wrote: > > > >> In case of multi-phy PHY providers, each PHY should be modeled as a sub > >> node of the PHY provider. Then each PHY will have a different node pointer > >> (node pointer of sub node) than that of PHY provider. Added this provision > >> in the PHY core. > >> Also fixed all drivers to use the updated API. > >> > >> Signed-off-by: Kishon Vijay Abraham I > >> --- > >> Documentation/phy.txt | 10 ++++++---- > >> drivers/phy/phy-bcm-kona-usb2.c | 2 +- > >> drivers/phy/phy-core.c | 25 ++++++++++++++++++------- > >> drivers/phy/phy-exynos-dp-video.c | 2 +- > >> drivers/phy/phy-exynos-mipi-video.c | 2 +- > >> drivers/phy/phy-exynos5-usbdrd.c | 3 ++- > >> drivers/phy/phy-exynos5250-sata.c | 2 +- > >> drivers/phy/phy-mvebu-sata.c | 2 +- > >> drivers/phy/phy-omap-usb2.c | 2 +- > >> drivers/phy/phy-samsung-usb2.c | 3 ++- > >> drivers/phy/phy-sun4i-usb.c | 2 +- > >> drivers/phy/phy-ti-pipe3.c | 2 +- > >> drivers/phy/phy-twl4030-usb.c | 2 +- > >> drivers/phy/phy-xgene.c | 2 +- > >> include/linux/phy/phy.h | 15 ++++++++++----- > >> 15 files changed, 48 insertions(+), 28 deletions(-) > > > > I wrote a very similar patch already. I knew I should have sent it on > > Friday. :( > > No problem! you can send your patch along with the MiPHY series. That's okay. It's silly for us both to submit the same patch and yours hit the MLs first & looks good so, the honour is yours. > > Patch looks good, just a real minor point. > > > >> phy->dev.class = phy_class; > >> phy->dev.parent = dev; > >> - phy->dev.of_node = dev->of_node; > >> + phy->dev.of_node = node?node:dev->of_node; > > > > There should be spaces either side of the '?' and ':', or you can do > > this more succinctly by: > > > > phy->dev.of_node = node ?: dev->of_node; > > > > Once fixed, feel free to add my: > > > > Acked-by: Lee Jones > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog