From: Peter Zijlstra <peterz@infradead.org>
To: Jason Low <jason.low2@hp.com>
Cc: torvalds@linux-foundation.org, paulmck@linux.vnet.ibm.com,
mingo@kernel.org, Waiman.Long@hp.com, davidlohr@hp.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
riel@redhat.com, rostedt@goodmis.org, akpm@linux-foundation.org,
hpa@zytor.com, tim.c.chen@linux.intel.com,
konrad.wilk@oracle.com, aswin@hp.com, scott.norton@hp.com,
chegu_vinod@hp.com, david@fromorbit.com
Subject: Re: [PATCH 0/4] MCS spinlocks: Cancellable MCS spinlock rework
Date: Mon, 7 Jul 2014 21:06:37 +0200 [thread overview]
Message-ID: <20140707190637.GI19379@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1404759019-4268-1-git-send-email-jason.low2@hp.com>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On Mon, Jul 07, 2014 at 11:50:15AM -0700, Jason Low wrote:
> The main purpose of this patchset is to reduce the size of the
> cancellable MCS spinlock and reduce the overhead of rwsem
> (currently the largest lock in the kernel).
>
> The overhead of the cancellable MCS lock is a pointer to a per-cpu node
> structure which requires 64 bits on 64 bit systems. Instead of a pointer
> to the per-cpu node, we can instead store the CPU # corresponding to the
> node in atomic_t. This reduces the overhead by 32 bits on 64 bit systems.
>
> This then opens the opportunity to reduce the size of the rw_semaphore
> structure (one of the current users of this MCS lock) by moving around some
> of its fields. Due to padding, we would reduce the size of that structure
> by 64 bits (on 64 bit systems). This makes it more in line with the size
> of the mutex structure.
Dave Chinner was very interested in this..
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-07-07 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 18:50 [PATCH 0/4] MCS spinlocks: Cancellable MCS spinlock rework Jason Low
2014-07-07 18:50 ` [PATCH 1/4] MCS spinlocks: Rename optimistic_spin_queue to optimistic_spin_node Jason Low
2014-07-07 18:50 ` [PATCH 2/4] MCS spinlocks: Convert osq lock to atomic_t to reduce overhead Jason Low
2014-07-08 13:38 ` Steven Rostedt
2014-07-08 16:44 ` Jason Low
2014-07-07 18:50 ` [PATCH 3/4] MCS spinlocks: Micro-optimize osq_unlock() Jason Low
2014-07-07 18:50 ` [PATCH 4/4] rwsem: Reduce the size of struct rw_semaphore Jason Low
2014-07-11 9:29 ` Peter Zijlstra
2014-07-07 19:06 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707190637.GI19379@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Waiman.Long@hp.com \
--cc=akpm@linux-foundation.org \
--cc=aswin@hp.com \
--cc=chegu_vinod@hp.com \
--cc=david@fromorbit.com \
--cc=davidlohr@hp.com \
--cc=hpa@zytor.com \
--cc=jason.low2@hp.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox