From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] memory: add a driver for atmel ram controllers
Date: Mon, 7 Jul 2014 21:44:06 +0200 [thread overview]
Message-ID: <20140707194406.GH3113@piout.net> (raw)
In-Reply-To: <20140707183340.GG9558@ns203013.ovh.net>
On 07/07/2014 at 20:33:40 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote :
> > + if (caps->has_mpddr_clk) {
> > + clk = devm_clk_get(&pdev->dev, "mpddr");
> > + if (WARN_ON(IS_ERR(clk)))
> > + return 0;
> I don't like this warn_on this need to be an error
What would you prefer ? pr_err() and panic or BUG_ON ?. We can also
probably simply put a single pr_err(), anyway, the platform will stop
just before switching to userspace.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-07 19:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 15:19 [PATCH 0/5] Add a driver for the atmel ram controller Alexandre Belloni
2014-07-07 15:19 ` [PATCH 1/5] memory: add a driver for atmel ram controllers Alexandre Belloni
2014-07-07 15:46 ` Boris BREZILLON
2014-07-07 17:56 ` Alexandre Belloni
2014-07-07 18:33 ` Jean-Christophe PLAGNIOL-VILLARD
2014-07-07 19:44 ` Alexandre Belloni [this message]
2014-07-07 15:19 ` [PATCH 2/5] ARM: at91: select ATMEL_RAMC when using OF Alexandre Belloni
2014-07-07 15:19 ` [PATCH 3/5] ARM: at91/dt: sama5d3: define mpddr clock and ramc clocks Alexandre Belloni
2014-07-07 18:32 ` Jean-Christophe PLAGNIOL-VILLARD
2014-07-07 19:55 ` Alexandre Belloni
2014-07-08 7:51 ` Maxime Ripard
2014-07-07 15:19 ` [PATCH 4/5] ARM: at91/dt: at91sam9: use ddrck in ramc Alexandre Belloni
2014-07-07 15:19 ` [PATCH 5/5] clk: at91: remove the useless CLK_IGNORE_UNUSED flag Alexandre Belloni
2014-07-07 17:03 ` [PATCH 0/5] Add a driver for the atmel ram controller Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707194406.GH3113@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox