Re: [PATCH] perf tool: Carve out ctype.h et al

Jiri Olsa
2014-07-07T21:08:28Z

On Mon, Jul 07, 2014 at 05:47:52PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sat, Jun 28, 2014 at 01:28:19AM +0200, Borislav Petkov escreveu:
> > On Thu, Jun 26, 2014 at 02:14:33PM +0200, Jiri Olsa wrote:
> > > this one compiles ok for me
>
> > Ok, cool. So guys, can we apply this one so that I can continue with the
> > next round?
>
> Sorry, but not yet, tried to build it (the version that Jiri said worked
> for him), after fixing up minor issues with blank lines being added to
> the end of two of the files and then:

yea, I meant it compiled for me ;-) I haven't reviewd the patch much,
one thing I remember is that it should be separated into smaller changes..
should I wait for new version or review this one?

>
> [acme@ssdandy linux]$ date ;time make -C tools/perf O=~/git/build/perf install-bin
> Seg Jul 7 17:44:20 BRT 2014
> make: Entering directory `/home/acme/git/linux/tools/perf'
> BUILD: Doing 'make -j8' parallel build
> config/Makefile:316: No libdw DWARF unwind found, Please install
> elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
>
> Auto-detecting system features:
> ... dwarf: [ on ]
> ... glibc: [ on ]
> ... gtk2: [ on ]
> ... libaudit: [ on ]
> ... libbfd: [ on ]
> ... libelf: [ on ]
> ... libnuma: [ on ]
> ... libperl: [ on ]
> ... libpython: [ on ]
> ... libslang: [ on ]
> ... libunwind: [ on ]
> ... libdw-dwarf-unwind: [ OFF ]
> ... DWARF post unwind library: libunwind
>
> make[1]: *** No rule to make target
> `/home/acme/git/linux/tools/lib/symbol/kallsyms.o', needed by
> `/home/acme/git/build/perf/libperf.a'. Stop.
> make[1]: *** Waiting for unfinished jobs....
> make: *** [install-bin] Error 2
> make: Leaving directory `/home/acme/git/linux/tools/perf'
>
> real 0m3.407s
> user 0m2.434s
> sys 0m0.819s
> [acme@ssdandy linux]$
>
> It builds ok if you do a build when CWD is tools/perf/, but who does
> that apart from Jiri? :-)

hehe.. so, is there something simpler than just typing 'make' ;-)

jirka