Re: [PATCH] perf tool: Carve out ctype.h et al

Jiri Olsa
2014-06-25T19:26:44Z

On Wed, Jun 25, 2014 at 11:23:04AM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Carve out ctype.* and util.* stuff into tools/lib/util/. We're keeping
> those as standalone object files in TOOLS_OBJS and add them to the
> targets that need them.
>
> This way we don't do lib archives but single objects only.

heya,
got following error;

[jolsa@krava perf]$ make
BUILD: Doing 'make -j4' parallel build
CC util/pmu.o
CC util/parse-events-flex.o
SUBDIR /home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/
util/pmu.c: In function ‘wordwrap’:
util/pmu.c:788:3: error: implicit declaration of function ‘isspace’ [-Werror=implicit-function-declaration]
while (isspace(*s))
^
cc1: all warnings being treated as errors
make[1]: *** [util/pmu.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2

Anyway, so you moved hex2u64, ctype interface under tools/lib
and made several Makefile changes to compile tools/lib objects.

Besides that we'd need all those changes separated, who is the
other user of this library? I dont see any in the patch.

thanks,
jirka