Re: [PATCH -v3 3/4] MCE, CE: Wire in the CE collector

Borislav Petkov
2014-07-07T22:09:23Z

On Mon, Jul 07, 2014 at 10:00:11AM -0700, Max Asbock wrote:
> The above code is a bit convoluted, it amounts to:
>
> if (we have a corrected dram error && we have an address for it)
> mce_ring_add()
> else
> mcelog()
>
> Is that the intention?

Yes.

> This might be problematic for downstream consumers of the errors
> such as the EDAC drivers which keep counts of errors. If errors are
> silently removed from the stream these counts will be bogus. Somebody
> might wonder why a page was off-lined while the EDAC driver reports
> zero corrected DRAM error counts.

This is one of the things that needs discussion. First of all, this
solution aims to be generic enough, even for boxes which don't have an
EDAC driver.

Because if you don't have an EDAC driver, you'd still want to have some
sort of error mitigation.

Granted, most boxes *do* have an EDAC driver but still...

Then, the question is becoming very interesting: how much do we want
EDAC to get involved in the whole deal? Because if we're doing the error
collecting, decaying and page offlining in the kernel, I don't see why
we would need EDAC at all. Or any other agent for that matter.

Maybe for the counters only, if we have to be fair. If, say, people
would want to monitor error levels or so.

I guess we can add some interface which only increments the error counts
without the other error handling EDAC normally would do...

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--