public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@freescale.com>
To: Sachin Kamat <spk.linux@gmail.com>
Cc: Fabian Frederick <fabf@skynet.be>,
	open list <linux-kernel@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO
Date: Tue, 8 Jul 2014 13:19:17 +0800	[thread overview]
Message-ID: <20140708051916.GB26257@dragon> (raw)
In-Reply-To: <CAK5sBcE2xxb1NGegn1L_CFH27vzx8kLg06u9fVTo6SZk8_6qJQ@mail.gmail.com>

On Tue, Jul 08, 2014 at 09:18:56AM +0530, Sachin Kamat wrote:
> Hi Shawn,
> 
> On Mon, Jul 7, 2014 at 11:25 AM, Shawn Guo <shawn.guo@freescale.com> wrote:
> > On Fri, Jul 04, 2014 at 09:03:10PM +0200, Fabian Frederick wrote:
> >> replace IS_ERR/PTR_ERR
> >>
> >> Cc: Shawn Guo <shawn.guo@freescale.com>
> >> Cc: Sascha Hauer <kernel@pengutronix.de>
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> >
> > Applied, thanks.
> 
> 
> I had sent a similar series [1] in May which you rejected. Just
> curious if something
> changed between then and now?

The main difference is this is the second attempt from a different
person to "clean up" the code.  I'm still not fond of the change, but
I'm getting tied to tell people about that, so just applied the change,
since after all it at least gives some good diffstat.

I would prefer Fabian's patch over yours because it's really good
enough to have one patch than 5 patches in a series to do the change for
IMX platform.

Shawn

  parent reply	other threads:[~2014-07-08  5:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 19:03 [PATCH 1/1] ARM: imx: use PTR_ERR_OR_ZERO Fabian Frederick
2014-07-07  5:55 ` Shawn Guo
2014-07-08  3:48   ` Sachin Kamat
2014-07-08  5:08     ` Fabian Frederick
2014-07-08  5:19     ` Shawn Guo [this message]
2014-07-08  6:19       ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140708051916.GB26257@dragon \
    --to=shawn.guo@freescale.com \
    --cc=fabf@skynet.be \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spk.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox