From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] ARM: at91/dt: sama5d3: define mpddr clock and ramc clocks
Date: Tue, 8 Jul 2014 09:51:06 +0200 [thread overview]
Message-ID: <20140708075105.GI13423@lukather> (raw)
In-Reply-To: <20140707195556.GI3113@piout.net>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
Hi,
On Mon, Jul 07, 2014 at 09:55:56PM +0200, Alexandre Belloni wrote:
> On 07/07/2014 at 20:32:36 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote :
> > > - compatible = "atmel,at91sam9g45-ddramc";
> > > + compatible = "atmel,sama5d3-mpddramc", "atmel,at91sam9g45-ddramc";
> > the sama5 ddr controler is not back compitble with 9g45 one the compatible is
> > wrong
>
> Keeping atmel,at91sam9g45-ddramc allows to reuse the old code for the
> iomap needed for the PM code without adding a new compatible in the
> ramc_ids[] array.
That looks like a pretty bad argument :)
If the two devices are not alike, they should have a different
compatible, it's as simple as that, and Linux should just deal with
it.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-08 7:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 15:19 [PATCH 0/5] Add a driver for the atmel ram controller Alexandre Belloni
2014-07-07 15:19 ` [PATCH 1/5] memory: add a driver for atmel ram controllers Alexandre Belloni
2014-07-07 15:46 ` Boris BREZILLON
2014-07-07 17:56 ` Alexandre Belloni
2014-07-07 18:33 ` Jean-Christophe PLAGNIOL-VILLARD
2014-07-07 19:44 ` Alexandre Belloni
2014-07-07 15:19 ` [PATCH 2/5] ARM: at91: select ATMEL_RAMC when using OF Alexandre Belloni
2014-07-07 15:19 ` [PATCH 3/5] ARM: at91/dt: sama5d3: define mpddr clock and ramc clocks Alexandre Belloni
2014-07-07 18:32 ` Jean-Christophe PLAGNIOL-VILLARD
2014-07-07 19:55 ` Alexandre Belloni
2014-07-08 7:51 ` Maxime Ripard [this message]
2014-07-07 15:19 ` [PATCH 4/5] ARM: at91/dt: at91sam9: use ddrck in ramc Alexandre Belloni
2014-07-07 15:19 ` [PATCH 5/5] clk: at91: remove the useless CLK_IGNORE_UNUSED flag Alexandre Belloni
2014-07-07 17:03 ` [PATCH 0/5] Add a driver for the atmel ram controller Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708075105.GI13423@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox