From: Mark Brown <broonie@kernel.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver
Date: Tue, 8 Jul 2014 09:52:47 +0200 [thread overview]
Message-ID: <20140708075247.GP30458@sirena.org.uk> (raw)
In-Reply-To: <1404745893-6379-2-git-send-email-iivanov@mm-sol.com>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Mon, Jul 07, 2014 at 06:11:30PM +0300, Ivan T. Ivanov wrote:
> +struct qpnp_pindesc {
> + u16 offset; /* address offset in SPMI device */
> + u32 index; /* offset from GPIO info base */
> + u8 type; /* peripheral hardware type */
> + u8 subtype; /* peripheral hardware subtype */
> + u8 major; /* digital major version */
> + u8 num_regs; /* control register count */
> + u8 cache[QPNP_NUM_CTL_REGS]; /* control register cache */
> +};
The device uses a regmap, why do you also need to open code a register
cache here?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-07-08 8:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 15:11 [PATCH 0/4] New Qualcomm PMIC pin controller drivers Ivan T. Ivanov
2014-07-07 15:11 ` [PATCH 1/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver Ivan T. Ivanov
2014-07-08 7:52 ` Mark Brown [this message]
2014-07-08 11:47 ` Ivan T. Ivanov
2014-07-07 15:11 ` [PATCH 2/4] pinctrl: qcom: Add documentation for pinctrl-qpnp binding Ivan T. Ivanov
2014-07-07 15:11 ` [PATCH 3/4] pinctrl: qcom: Add PM8941 and PM8941 pinctrl drivers Ivan T. Ivanov
2014-07-07 15:11 ` [PATCH 4/4] ARM: dts: qcom: Add PM8941 and PM8841 pinctrl nodes Ivan T. Ivanov
2014-07-09 9:43 ` [PATCH 0/4] New Qualcomm PMIC pin controller drivers Linus Walleij
2014-07-09 11:13 ` Ivan T. Ivanov
2014-07-09 11:43 ` Linus Walleij
2014-07-09 14:02 ` Bjorn Andersson
2014-07-10 13:39 ` Ivan T. Ivanov
2014-07-12 23:51 ` Bjorn Andersson
2014-07-14 15:00 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708075247.GP30458@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox