From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH] blk-lib: fix error reporting
Date: Tue, 8 Jul 2014 02:50:38 -0700 [thread overview]
Message-ID: <20140708095038.GA31180@infradead.org> (raw)
In-Reply-To: <alpine.LRH.2.02.1407031514320.3347@file01.intranet.prod.int.rdu2.redhat.com>
> + if (unlikely(err))
> + ACCESS_ONCE(bb->error) = err;
I can't see a reason for the ACCESS_ONCE here.
Also the likely/unlikely annotations here smell like premature
optimization.
Otherwise looks good to me.
next prev parent reply other threads:[~2014-07-08 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 19:16 [PATCH] blk-lib: fix error reporting Mikulas Patocka
2014-07-08 9:50 ` Christoph Hellwig [this message]
2014-07-08 13:05 ` [dm-devel] " Mikulas Patocka
2014-07-08 14:04 ` James Bottomley
2014-07-16 10:22 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708095038.GA31180@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox