From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cheng-Wei Lee <lee.rhapsody@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>,
Avinash Kumar <avi.kp.137@gmail.com>,
Peter Senna Tschudin <peter.senna@gmail.com>,
devel <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations
Date: Tue, 8 Jul 2014 13:28:30 +0300 [thread overview]
Message-ID: <20140708102830.GK25880@mwanda> (raw)
In-Reply-To: <CAJKoSVTzYbuzmh6NOpXZ8hd5B_X3fWoik_w9AQJ=0RaCo40rBA@mail.gmail.com>
On Wed, Jun 25, 2014 at 11:25:33PM +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
> b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 07cee56..99e2f2d 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3533,7 +3533,7 @@ static void hfa384x_usbin_rx(wlandevice_t
> *wlandev, struct sk_buff *skb)
> }
>
> done:
> - return;
> + pr_debug("hfa384x_usbin_rx: done\n");
Don't add this stuff. Just delete the useless label.
regards,
dan carpenter
prev parent reply other threads:[~2014-07-08 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 15:25 [PATCH 2/2] staging: wlan-ng/hfa384x_usb.c: add blank line after declarations Cheng-Wei Lee
2014-07-08 10:28 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708102830.GK25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=avi.kp.137@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.rhapsody@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=shehabaldin.sherif@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox