From: Tejun Heo <tj@kernel.org>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Jet Chen <jet.chen@intel.com>, Su Tao <tao.su@intel.com>,
Yuanhan Liu <yuanhan.liu@intel.com>, LKP <lkp@01.org>,
linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [workqueue] WARNING: CPU: 0 PID: 76 at drivers/block/floppy.c:968 schedule_bh()
Date: Tue, 8 Jul 2014 10:46:32 -0400 [thread overview]
Message-ID: <20140708144632.GF4979@htj.dyndns.org> (raw)
In-Reply-To: <20140708140430.GE4979@htj.dyndns.org>
On Tue, Jul 08, 2014 at 10:04:30AM -0400, Tejun Heo wrote:
...
> Hmmm... this is schedule_bh() in floppy.c complaining that the work
> item is already pending. The cond_resched() addition by b22ce2785d97
> doesn't change the semantics around work item execution although it
> could have exposed an existing problem in the floppy driver. I'll
> look into how this could happen.
It doesn't reproduce here and nothing really stands out to me. It
probably involves floppy_work requeueing itself and something else
getting executed inbetween which wouldn't have happend before, but I
can't figure out what that could be and either can I follow the
control flow the driver. :)
Jiri, any ideas?
Thanks.
--
tejun
next prev parent reply other threads:[~2014-07-08 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 2:11 [workqueue] WARNING: CPU: 0 PID: 76 at drivers/block/floppy.c:968 schedule_bh() Fengguang Wu
2014-07-08 14:04 ` Tejun Heo
2014-07-08 14:46 ` Tejun Heo [this message]
2014-07-08 14:56 ` Jiri Kosina
2014-07-11 13:27 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708144632.GF4979@htj.dyndns.org \
--to=tj@kernel.org \
--cc=fengguang.wu@intel.com \
--cc=jet.chen@intel.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=tao.su@intel.com \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox