From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org, gulsah.1004@gmail.com,
gregkh@linuxfoundation.org, linville@tuxdriver.com,
paulmck@linux.vnet.ibm.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8192ee: Correct bitmask in comparsion
Date: Tue, 8 Jul 2014 18:07:22 +0300 [thread overview]
Message-ID: <20140708150722.GP25880@mwanda> (raw)
In-Reply-To: <1404827699-7295-1-git-send-email-andrey.krieger.utkin@gmail.com>
On Tue, Jul 08, 2014 at 04:54:59PM +0300, Andrey Utkin wrote:
> The issue is discovered by static checker. The proposed change (0x000c0
> -> 0x000c) is likely correct because:
> 1. 16-bit `map` holds value coming from struct
> ieee80211_vht_mcs_info.tx_mcs_map, which is described so: "TX MCS map 2
> bits for each stream, total 8 streams". The changed code refers to case
> of 2 TX streams, and 0x000c mask filters two bits related to the second
> stream. Some codelines below 0x0003 mask is used to test first stream.
> 2. Mask 0x000c is used 3 more times in that place.
> 3. Specifying 5 digits of hex value is uncommon, especially while working
> with `u16` variable. So likely the trailing zero is a typo.
This changelog is perfect. Thanks.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-08 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 13:54 [PATCH] staging: rtl8192ee: Correct bitmask in comparsion Andrey Utkin
2014-07-08 15:07 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-04 23:40 Andrey Utkin
2014-07-08 11:49 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708150722.GP25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andrey.krieger.utkin@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gulsah.1004@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox