* [PATCH 1/1] staging: cxt1e1: remove null test before kfree
@ 2014-07-04 19:58 Fabian Frederick
2014-07-08 23:38 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-07-04 19:58 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Greg Kroah-Hartman, Daeseok Youn, devel
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Daeseok Youn <daeseok.youn@gmail.com>
Cc: devel@driverdev.osuosl.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/staging/cxt1e1/pmcc4_drv.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/cxt1e1/pmcc4_drv.c b/drivers/staging/cxt1e1/pmcc4_drv.c
index 76bebdd..e738264 100644
--- a/drivers/staging/cxt1e1/pmcc4_drv.c
+++ b/drivers/staging/cxt1e1/pmcc4_drv.c
@@ -454,10 +454,7 @@ c4_cleanup (void)
pi = &ci->port[portnum];
c4_wq_port_cleanup (pi);
for (j = 0; j < MUSYCC_NCHANS; j++)
- {
- if (pi->chan[j])
- kfree(pi->chan[j]); /* free mch_t struct */
- }
+ kfree(pi->chan[j]); /* free mch_t struct */
kfree(pi->regram_saved);
}
kfree(ci->iqd_p_saved);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] staging: cxt1e1: remove null test before kfree
2014-07-04 19:58 [PATCH 1/1] staging: cxt1e1: remove null test before kfree Fabian Frederick
@ 2014-07-08 23:38 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2014-07-08 23:38 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Daeseok Youn, devel
On Fri, Jul 04, 2014 at 09:58:15PM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Daeseok Youn <daeseok.youn@gmail.com>
> Cc: devel@driverdev.osuosl.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/staging/cxt1e1/pmcc4_drv.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
This driver has been deleted in the tree, sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-08 23:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-04 19:58 [PATCH 1/1] staging: cxt1e1: remove null test before kfree Fabian Frederick
2014-07-08 23:38 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox