public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Fabio Falzoi <fabio.falzoi84@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	joe@perches.com, dan.carpenter@oracle.com,
	wei_wang@realsil.com.cn, micky_ching@realsil.com.cn
Subject: Re: [PATCH v3 1/4] Staging: rts5208: Replace custom macro with pr_debug
Date: Tue, 8 Jul 2014 16:46:10 -0700	[thread overview]
Message-ID: <20140708234610.GB25645@kroah.com> (raw)
In-Reply-To: <1404855512-5864-2-git-send-email-fabio.falzoi84@gmail.com>

On Tue, Jul 08, 2014 at 11:38:29PM +0200, Fabio Falzoi wrote:
> Use pr_debug macro to control tracing verbosity through dynamic debug facility.

For almost all of these, you should use dev_dbg() instead, as you have
access to a struct device (well, you should have, you might have to dig
for it...)

thanks,

greg k-h

  reply	other threads:[~2014-07-08 23:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 21:38 [PATCH v3 0/4] Staging: rts5208: Use standard debug features Fabio Falzoi
2014-07-08 21:38 ` [PATCH v3 1/4] Staging: rts5208: Replace custom macro with pr_debug Fabio Falzoi
2014-07-08 23:46   ` Greg KH [this message]
2014-07-08 21:38 ` [PATCH v3 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes Fabio Falzoi
2014-07-08 23:45   ` Greg KH
2014-07-09  1:48     ` Joe Perches
2014-07-09  5:29       ` Greg KH
2014-07-08 21:38 ` [PATCH v3 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option Fabio Falzoi
2014-07-08 21:38 ` [PATCH v3 4/4] Staging: rts5208: Fix a format specifier for dev_err Fabio Falzoi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140708234610.GB25645@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabio.falzoi84@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=micky_ching@realsil.com.cn \
    --cc=wei_wang@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox