public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] staging: speakup: main.c - use time_after()
@ 2014-07-01  7:00 Anil Belur
  2014-07-08 23:51 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Anil Belur @ 2014-07-01  7:00 UTC (permalink / raw)
  To: shalinmehta85, dan.carpenter, daeseok.youn, gregkh
  Cc: speakup, devel, linux-kernel, Anil Belur

From: Anil Belur <askb23@gmail.com>

- this patch fixes jiffies comparision with a safer function to prevent
  any overflows

Signed-off-by: Anil Belur <askb23@gmail.com>
---
 drivers/staging/speakup/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index 7de79d5..0cd3cdb 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2067,7 +2067,7 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym,
 			if (up_flag)
 				goto out;
 			if (last_keycode == keycode &&
-			    last_spk_jiffy + MAX_DELAY > jiffies) {
+			    time_after(last_spk_jiffy + MAX_DELAY, jiffies)) {
 				spk_close_press = 1;
 				offset = spk_shift_table[shift_info + 32];
 				/* double press? */
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] staging: speakup: main.c - use time_after()
  2014-07-01  7:00 [PATCH 1/1] staging: speakup: main.c - use time_after() Anil Belur
@ 2014-07-08 23:51 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-07-08 23:51 UTC (permalink / raw)
  To: Anil Belur
  Cc: shalinmehta85, dan.carpenter, daeseok.youn, devel, speakup,
	linux-kernel

On Tue, Jul 01, 2014 at 12:30:22PM +0530, Anil Belur wrote:
> From: Anil Belur <askb23@gmail.com>
> 
> - this patch fixes jiffies comparision with a safer function to prevent
>   any overflows
> 
> Signed-off-by: Anil Belur <askb23@gmail.com>
> ---
>  drivers/staging/speakup/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This change is already in my tree, what branch are you working against?

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-08 23:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-01  7:00 [PATCH 1/1] staging: speakup: main.c - use time_after() Anil Belur
2014-07-08 23:51 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox