From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
wei_wang@realsil.com.cn, Fabio Falzoi <fabio.falzoi84@gmail.com>,
dan.carpenter@oracle.com
Subject: Re: [PATCH v3 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes
Date: Tue, 8 Jul 2014 22:29:50 -0700 [thread overview]
Message-ID: <20140709052950.GA8051@kroah.com> (raw)
In-Reply-To: <1404870498.932.79.camel@joe-AO725>
On Tue, Jul 08, 2014 at 06:48:18PM -0700, Joe Perches wrote:
> On Tue, 2014-07-08 at 16:45 -0700, Greg KH wrote:
> > On Tue, Jul 08, 2014 at 11:38:30PM +0200, Fabio Falzoi wrote:
> > > Use print_hex_dump_bytes to have memory properly dumped only when
> > > DEBUG is defined.
> []
> > > diff --git a/drivers/staging/rts5208/trace.h b/drivers/staging/rts5208/trace.h
> []
> > > @@ -82,12 +82,11 @@ static inline char *filename(char *path)
> []
> > > +static inline void rtsx_hex_dump(const void *buf, size_t len)
> > > +{
> > > +#ifdef DEBUG
> > > + print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE, buf, len);
> > > #endif
> > > +}
> >
> > What a mess. What's wrong with just using the %*ph modifier in
> > dev_dbg() like other drivers do?
>
> Dunno.
> Is it ever desired to emit more than 64 bytes of buf?
I doubt it really matters :)
next prev parent reply other threads:[~2014-07-09 5:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 21:38 [PATCH v3 0/4] Staging: rts5208: Use standard debug features Fabio Falzoi
2014-07-08 21:38 ` [PATCH v3 1/4] Staging: rts5208: Replace custom macro with pr_debug Fabio Falzoi
2014-07-08 23:46 ` Greg KH
2014-07-08 21:38 ` [PATCH v3 2/4] Staging: rts5208: Replace custom macro with print_hex_dump_bytes Fabio Falzoi
2014-07-08 23:45 ` Greg KH
2014-07-09 1:48 ` Joe Perches
2014-07-09 5:29 ` Greg KH [this message]
2014-07-08 21:38 ` [PATCH v3 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option Fabio Falzoi
2014-07-08 21:38 ` [PATCH v3 4/4] Staging: rts5208: Fix a format specifier for dev_err Fabio Falzoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709052950.GA8051@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox