From: Dan Carpenter <dan.carpenter@oracle.com>
To: sanjeev sharma <sanjeevsharmaengg@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
peter.senna@gmail.com, linux-kernel@vger.kernel.org,
rmfrfs@gmail.com, teobaluta@gmail.com,
Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
Subject: Re: [PATCH v2 1/4] staging: rtl8192u: Remove useless return statement in r819xU_phy.c
Date: Wed, 9 Jul 2014 11:09:43 +0300 [thread overview]
Message-ID: <20140709080943.GT25880@mwanda> (raw)
In-Reply-To: <1404885860-19468-2-git-send-email-sanjeevsharmaengg@gmail.com>
These patches look ok now. The only thing is that the changelogs are
a little off.
On Wed, Jul 09, 2014 at 11:34:17AM +0530, sanjeev sharma wrote:
> From: sanjeev sharma <sanjeev_sharma@mentor.com>
Don't use the From header unless you are sending patches on behalf of
someone else. It's better if you can configure your email client so you
can send the patches from your @mentor.com address. It would be better
if the names were capitalized.
>
> This is a patch to the r819xU_phy.c file that remove unneeded return statements in code.
Please line wrap the changelog at 72 characters (the same as email).
Otherwise Greg sometimes fixes them manually...
But the patches themselves are nice now.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-09 8:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 6:04 [PATCH] staging: rtl8192u: fix checkpatch error/warning in r819xU_phy.c sanjeev sharma
2014-07-08 7:43 ` Dan Carpenter
[not found] ` <CAGUYZuQgpNQRRg5X_AYv_iW5W60EdEwo0VOe3EJAPJocKrTf3g@mail.gmail.com>
2014-07-08 10:01 ` Dan Carpenter
2014-07-09 6:04 ` [PATCH v2 0/4] Fix checkpatch reported problem " sanjeev sharma
2014-07-09 6:04 ` [PATCH v2 1/4] staging: rtl8192u: Remove useless return statement " sanjeev sharma
2014-07-09 8:09 ` Dan Carpenter [this message]
2014-07-09 10:14 ` Sharma, Sanjeev
2014-07-09 6:04 ` [PATCH v2 2/4] staging: rtl8192u: Removed unnecessary whitespace & tab warning " sanjeev sharma
2014-07-09 6:04 ` [PATCH v2 3/4] staging: rtl8192u: Fixed switch and case indentation error " sanjeev sharma
2014-07-09 6:04 ` [PATCH v2 4/4] staging: rtl8192u: Fixed too long lines " sanjeev sharma
2014-07-09 12:19 ` [PATCH v3 0/4] line wrapping of changelog sanjeev sharma
2014-07-09 12:15 ` Dan Carpenter
2014-07-09 12:19 ` [PATCH v3 1/4] staging: rtl8192u: Remove useless return statements sanjeev sharma
2014-07-09 19:24 ` Greg KH
2014-07-10 12:19 ` Sharma, Sanjeev
2014-07-09 12:19 ` [PATCH v3 2/4] staging: rtl8192u: Removed unnecessary whitespace & tab warning sanjeev sharma
2014-07-09 12:19 ` [PATCH v3 3/4] staging: rtl8192u: Fixed switch and case indentation error sanjeev sharma
2014-07-09 12:19 ` [PATCH v3 4/4] staging: rtl8192u: Fixed too long lines sanjeev sharma
2014-07-09 12:56 ` Joe Perches
2014-07-10 12:18 ` Sharma, Sanjeev
2014-07-10 12:24 ` [PATCH v4 0/4] staging: rtl8192u: checkpatch fixes sanjeev sharma
2014-07-10 12:24 ` [PATCH v4 1/4] staging: rtl8192u: Remove useless return statement sanjeev sharma
2014-07-10 12:24 ` [PATCH v4 2/4] staging: rtl8192u: Removed unnecessary whitespace & tab warning sanjeev sharma
2014-07-10 22:15 ` Greg KH
2014-07-10 12:24 ` [PATCH v4 3/4] staging: rtl8192u: Fixed switch and case indentation error sanjeev sharma
2014-07-10 12:24 ` [PATCH v4 4/4] staging: rtl8192u: Fixed too long line sanjeev sharma
2014-07-10 22:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709080943.GT25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Sanjeev_Sharma@mentor.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=rmfrfs@gmail.com \
--cc=sanjeevsharmaengg@gmail.com \
--cc=teobaluta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox