From: Dan Carpenter <dan.carpenter@oracle.com>
To: Davide Gianforte <davide@gengisdave.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] staging: silicom: checkpatch fixes
Date: Wed, 9 Jul 2014 12:38:08 +0300 [thread overview]
Message-ID: <20140709093808.GU25880@mwanda> (raw)
In-Reply-To: <1972083.WZLDx2N35Z@mayhem>
The patch does too many things, break it up into one type of fix per
patch.
On Tue, Jul 01, 2014 at 02:24:36PM +0200, Davide Gianforte wrote:
> Chechpatch.pl cleanup
>
> There are still some warnings, most of them are lines over 80 chars
> (mainly a semicolon or closing parenthesis).
>
> Where not specified, I defaulted printk with no log level into pr_debug
No. You can't just use pr_debug for everything. Also some of them are
not whole line prints so the pr_debug() will put extra info in the
middle of the lines.
Write a hello_world.ko kernel module and play with the printk until you
understand what I mean.
regards,
dan carpenter
prev parent reply other threads:[~2014-07-09 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 12:24 [PATCH 1/2] staging: silicom: checkpatch fixes Davide Gianforte
2014-07-01 12:33 ` [PATCH 2/2] staging: silicom: function return fixes Davide Gianforte
2014-07-09 18:59 ` Greg Kroah-Hartman
2014-07-11 7:12 ` Davide Gianforte
2014-07-11 13:31 ` Dan Carpenter
2014-07-09 9:38 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709093808.GU25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davide@gengisdave.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox