From: Olaf Hering <olaf@aepfle.de>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
xen-devel@lists.xenproject.org,
Andrew Morton <akpm@linux-foundation.org>,
Michael Holzheu <holzheu@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] mmap_vmcore: skip non-ram pages reported by hypervisors
Date: Wed, 9 Jul 2014 12:12:15 +0200 [thread overview]
Message-ID: <20140709101215.GA31182@aepfle.de> (raw)
In-Reply-To: <87mwciooe7.fsf@vitty.brq.redhat.com>
On Wed, Jul 09, Vitaly Kuznetsov wrote:
> > Also I am wondering why it was not done as part of copy_oldmem_page()
> > so that respective arch could hide all the details.
> Afaiac that wouldn't solve the mmap issue I'm trying to address but we
> can ask Olaf why he preferred pfn_is_ram() path.
Every copy_oldmem_page would need to know about the pfn_is_ram function,
so I think its better to keep that part of the code private to
fs/proc/vmcore.c
Perhaps pfn_is_ram could be named pfn_is_backed_by_ram, but the comments
make it clear what the function does.
Olaf
prev parent reply other threads:[~2014-07-09 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 15:05 [PATCH] mmap_vmcore: skip non-ram pages reported by hypervisors Vitaly Kuznetsov
2014-07-07 20:33 ` Andrew Morton
2014-07-08 8:08 ` Vitaly Kuznetsov
2014-07-08 16:25 ` [Xen-devel] " David Vrabel
2014-07-09 9:17 ` Vitaly Kuznetsov
2014-07-09 9:46 ` David Vrabel
2014-07-08 16:29 ` Konrad Rzeszutek Wilk
2014-07-09 9:23 ` Vitaly Kuznetsov
2014-07-08 19:11 ` Vivek Goyal
2014-07-09 9:46 ` Vitaly Kuznetsov
2014-07-09 10:12 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709101215.GA31182@aepfle.de \
--to=olaf@aepfle.de \
--cc=akpm@linux-foundation.org \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=vkuznets@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox