From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: lizefan@huawei.com, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, hannes@cmpxchg.org, mhocko@suse.cz,
axboe@kernel.dk
Subject: Re: [PATCH v2 6/6] blkcg, memcg: make blkcg depend on memcg on the default hierarchy
Date: Wed, 9 Jul 2014 07:57:46 -0400 [thread overview]
Message-ID: <20140709115746.GA26504@redhat.com> (raw)
In-Reply-To: <20140708215351.GJ4979@htj.dyndns.org>
On Tue, Jul 08, 2014 at 05:53:51PM -0400, Tejun Heo wrote:
> Hello, Vivek.
>
> On Tue, Jul 08, 2014 at 03:42:26PM -0400, Vivek Goyal wrote:
> > I have couple questions about new semantics. Following is my
> > understanding. Is it right?
> >
> > - So after this change one can not use blkio controller on unified
> > hiearchy if memory controller is mounted on some other hierarchy
> > and is not available for mounting unified hiearchy.
>
> Hmmm? No, the only behavior which changes is when both blkcg and
> memcg are mounted on the unified hierarchy. Nothing else changes.
> The dependency behavior kicks in iff memcg is available on the unified
> hierarchy.
Ok, good to know that dependency kicks in only if controlle being depended
on is available on the hierarchy.
>
> > - If blkio controller is enabled on unified hiearchy (memory controller
> > implicitly enabled), then one can't mount memory controller on other
> > hierarchies without first disabling blkio controller on unified hiearchy.
>
> Yes, blkio needs to be disabled to the root for memcg to be able to
> become free. This is an extra restriction but I don't think it's
> anything drastic. Once a controller starts being actively used on any
> hierarchy, nothing has been guaranteed about when the controller would
> become free again even if the whole hierarchy is reduced to the root.
Agreed. Thanks for the clarification.
Thanks
Vivek
next prev parent reply other threads:[~2014-07-09 11:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 1:03 [PATCHSET cgroup/for-3.17] cgroup, blkcg, memcg: make blkcg depend on memcg on unified hierarchy Tejun Heo
2014-06-28 1:03 ` [PATCH 1/6] cgroup: reorganize cgroup_subtree_control_write() Tejun Heo
2014-06-28 1:03 ` [PATCH 2/6] cgroup: introduce cgroup->subtree_control Tejun Heo
2014-06-28 1:03 ` [PATCH 3/6] cgroup: make interface files visible iff enabled on cgroup->subtree_control Tejun Heo
2014-06-28 1:03 ` [PATCH 4/6] cgroup: implement cgroup_subsys->css_reset() Tejun Heo
2014-06-28 1:03 ` [PATCH 5/6] cgroup: implement cgroup_subsys->depends_on Tejun Heo
2014-06-28 1:03 ` [PATCH 6/6] blkcg, memcg: make blkcg depend on memcg on the default hierarchy Tejun Heo
2014-06-28 11:49 ` [PATCH v2 " Tejun Heo
2014-07-08 19:42 ` Vivek Goyal
2014-07-08 21:53 ` Tejun Heo
2014-07-09 11:57 ` Vivek Goyal [this message]
2014-07-04 6:29 ` [PATCHSET cgroup/for-3.17] cgroup, blkcg, memcg: make blkcg depend on memcg on unified hierarchy Li Zefan
2014-07-07 18:33 ` Johannes Weiner
2014-07-08 22:03 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709115746.GA26504@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).