Re: [PATCH v3 4/7] xen/pciback: Implement PCI reset slot or bus with 'do_flr' SysFS attribute

Konrad Rzeszutek Wilk
2014-07-08T18:46:36Z

On Tue, Jul 08, 2014 at 07:02:51PM +0100, David Vrabel wrote:
> On 08/07/14 19:58, konrad@kernel.org wrote:
> > --- a/Documentation/ABI/testing/sysfs-driver-pciback
> > +++ b/Documentation/ABI/testing/sysfs-driver-pciback
> > @@ -82,3 +82,14 @@ Description:
> > device is shared, enabled, or on a level interrupt line.
> > Writing a string of DDDD:BB:DD.F will toggle the state.
> > This is Domain:Bus:Device.Function where domain is optional.
> > +
> > +What: /sys/bus/pci/drivers/pciback/do_flr
> > +Date: July 2014
> > +KernelVersion: 3.16
> > +Contact: xen-devel@lists.xenproject.org
> > +Description:
> > + An option to slot or bus reset an PCI device owned by
> > + Xen PCI backend. Writing a string of DDDD:BB:DD.F will cause
> > + the driver to perform an slot or bus reset if the device
> > + supports. It also checks to make sure that all of the devices
> > + under the bridge are owned by Xen PCI backend.
>
> Not sure I like this new interface. I solved this by adding a new reset
> file that looked like the regular one the pci would have if it supported
> FLR. I'm fairly sure I posted a series for this. Was there a reason
> you didn't do this?

It did not work.

During bootup kobject would complain about a secondary 'reset' SysFS
on the PCI device.

>
> David