From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
"open list:READ-COPY UPDATE..." <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] rcu: use true/false instead of 1/0 for a bool type
Date: Wed, 9 Jul 2014 09:42:42 -0700 [thread overview]
Message-ID: <20140709164242.GP4603@linux.vnet.ibm.com> (raw)
In-Reply-To: <1404878897-3680-1-git-send-email-bobby.prani@gmail.com>
On Wed, Jul 09, 2014 at 12:08:17AM -0400, Pranith Kumar wrote:
> One more bool type change which I found while reading the code.
>
> Use true/false instead of 0/1 for a bool type
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Queued for 3.18, thank you!
Thanx, Paul
> ---
> kernel/rcu/tree.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 1b70cb6..bc7b6f1 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -1668,7 +1668,7 @@ static int rcu_gp_fqs(struct rcu_state *rsp, int fqs_state_in)
> if (fqs_state == RCU_SAVE_DYNTICK) {
> /* Collect dyntick-idle snapshots. */
> if (is_sysidle_rcu_state(rsp)) {
> - isidle = 1;
> + isidle = true;
> maxj = jiffies - ULONG_MAX / 4;
> }
> force_qs_rnp(rsp, dyntick_save_progress_counter,
> @@ -1677,7 +1677,7 @@ static int rcu_gp_fqs(struct rcu_state *rsp, int fqs_state_in)
> fqs_state = RCU_FORCE_QS;
> } else {
> /* Handle dyntick-idle and offline CPUs. */
> - isidle = 0;
> + isidle = false;
> force_qs_rnp(rsp, rcu_implicit_dynticks_qs, &isidle, &maxj);
> }
> /* Clear flag to prevent immediate re-entry. */
> @@ -2449,7 +2449,7 @@ static void force_qs_rnp(struct rcu_state *rsp,
> for (; cpu <= rnp->grphi; cpu++, bit <<= 1) {
> if ((rnp->qsmask & bit) != 0) {
> if ((rnp->qsmaskinit & bit) != 0)
> - *isidle = 0;
> + *isidle = false;
> if (f(per_cpu_ptr(rsp->rda, cpu), isidle, maxj))
> mask |= bit;
> }
> --
> 1.9.1
>
prev parent reply other threads:[~2014-07-09 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 4:08 [PATCH 1/1] rcu: use true/false instead of 1/0 for a bool type Pranith Kumar
2014-07-09 16:42 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709164242.GP4603@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=bobby.prani@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox