From: Greg KH <greg@kroah.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: balbi@ti.com, tony@atomide.com, linux@arm.linux.org.uk,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Removes FIXME message in usb.c
Date: Wed, 9 Jul 2014 10:19:30 -0700 [thread overview]
Message-ID: <20140709171930.GA11527@kroah.com> (raw)
In-Reply-To: <1404924948-3298-1-git-send-email-xerofoify@gmail.com>
Ok, this has been fun to watch on lkml for a while now, but really,
please, just stop doing this. Randomly searching the kernel source for
FIXME lines and just commenting them out, isn't ok. Almost always,
those lines are there because the original developer really doesn't know
how else to resolve the issue.
So, if the domain-specific-author doesn't have an idea of what to do,
how does someone who is brand-new to the code know better?
If you are looking for a task to do in the kernel, try
drivers/staging/*/TODO for a list. Or look at the kernel janitor's list
on kernelnewbies.org. Or try running the kernel and finding something
that is broken for you and fixing that. Any of those would be better
than randomly deleting FIXME lines. By doing that, you are just wasting
maintainer's time. Which is the resource we have the least of at the
moment.
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-09 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 16:55 [PATCH] Removes FIXME message in usb.c Nicholas Krause
2014-07-09 17:19 ` Greg KH [this message]
2014-07-09 17:28 ` Nick Krause
-- strict thread matches above, loose matches on Subject: below --
2014-07-09 1:58 Nicholas Krause
2014-07-09 5:30 ` Greg KH
2014-07-09 7:25 ` Uwe Kleine-König
2014-07-09 12:55 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709171930.GA11527@kroah.com \
--to=greg@kroah.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox