* [PATCH] staging: nvec: add missing blank line after declarations
@ 2014-07-07 16:05 Pawel Lebioda
2014-07-09 19:16 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Pawel Lebioda @ 2014-07-07 16:05 UTC (permalink / raw)
To: Julian Andres Klode, Marc Dietrich
Cc: Greg Kroah-Hartman, ac100, linux-tegra, devel, linux-kernel
Fix 'missing blank line after declaration' warnings reported by checkpatch.pl.
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
---
drivers/staging/nvec/nvec_paz00.c | 1 +
drivers/staging/nvec/nvec_power.c | 1 +
drivers/staging/nvec/nvec_ps2.c | 2 ++
3 files changed, 4 insertions(+)
diff --git a/drivers/staging/nvec/nvec_paz00.c b/drivers/staging/nvec/nvec_paz00.c
index 934b796..e2e675a 100644
--- a/drivers/staging/nvec/nvec_paz00.c
+++ b/drivers/staging/nvec/nvec_paz00.c
@@ -35,6 +35,7 @@ static void nvec_led_brightness_set(struct led_classdev *led_cdev,
{
struct nvec_led *led = to_nvec_led(led_cdev);
unsigned char buf[] = NVEC_LED_REQ;
+
buf[4] = value;
nvec_write_async(led->nvec, buf, sizeof(buf));
diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_power.c
index aacfcd6..6446e15 100644
--- a/drivers/staging/nvec/nvec_power.c
+++ b/drivers/staging/nvec/nvec_power.c
@@ -226,6 +226,7 @@ static int nvec_power_get_property(struct power_supply *psy,
union power_supply_propval *val)
{
struct nvec_power *power = dev_get_drvdata(psy->dev->parent);
+
switch (psp) {
case POWER_SUPPLY_PROP_ONLINE:
val->intval = power->on;
diff --git a/drivers/staging/nvec/nvec_ps2.c b/drivers/staging/nvec/nvec_ps2.c
index 45b2f13..f56f1db 100644
--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -53,12 +53,14 @@ static struct nvec_ps2 ps2_dev;
static int ps2_startstreaming(struct serio *ser_dev)
{
unsigned char buf[] = { NVEC_PS2, AUTO_RECEIVE_N, PACKET_SIZE };
+
return nvec_write_async(ps2_dev.nvec, buf, sizeof(buf));
}
static void ps2_stopstreaming(struct serio *ser_dev)
{
unsigned char buf[] = { NVEC_PS2, CANCEL_AUTO_RECEIVE };
+
nvec_write_async(ps2_dev.nvec, buf, sizeof(buf));
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: nvec: add missing blank line after declarations
2014-07-07 16:05 [PATCH] staging: nvec: add missing blank line after declarations Pawel Lebioda
@ 2014-07-09 19:16 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2014-07-09 19:16 UTC (permalink / raw)
To: Pawel Lebioda
Cc: Julian Andres Klode, Marc Dietrich, ac100, linux-tegra, devel,
linux-kernel
On Mon, Jul 07, 2014 at 06:05:41PM +0200, Pawel Lebioda wrote:
> Fix 'missing blank line after declaration' warnings reported by checkpatch.pl.
> Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
> ---
> drivers/staging/nvec/nvec_paz00.c | 1 +
> drivers/staging/nvec/nvec_power.c | 1 +
> drivers/staging/nvec/nvec_ps2.c | 2 ++
> 3 files changed, 4 insertions(+)
I applied your first version of this patch :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-09 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-07 16:05 [PATCH] staging: nvec: add missing blank line after declarations Pawel Lebioda
2014-07-09 19:16 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox