* [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning correction
@ 2014-07-06 9:05 Sami Laine
2014-07-09 19:23 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sami Laine @ 2014-07-06 9:05 UTC (permalink / raw)
To: gregkh; +Cc: standby24x7, sachin.kamat, devel, linux-kernel, trivial
From: Sami Laine <laine.j.sami@gmail.com>
Sparse warning correction:
vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was
not declared. Should it be static?
Signed-off-by: Sami Laine <laine.j.sami@gmail.com>
---
diff --git a/drivers/staging/rtl8821ae/debug.c b/drivers/staging/rtl8821ae/debug
index 8aefbf1..e4a19ba 100644
--- a/drivers/staging/rtl8821ae/debug.c
+++ b/drivers/staging/rtl8821ae/debug.c
@@ -77,7 +77,7 @@ void rtl_dbgp_flag_init(struct ieee80211_hw *hw)
/*Init Debug flag enable condition */
}
-struct proc_dir_entry *proc_topdir;
+static struct proc_dir_entry *proc_topdir;
static int rtl_proc_get_mac_0(struct seq_file *m, void *v)
{
struct ieee80211_hw *hw = m->private;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning correction
2014-07-06 9:05 [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning correction Sami Laine
@ 2014-07-09 19:23 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-07-09 19:23 UTC (permalink / raw)
To: Sami Laine; +Cc: sachin.kamat, devel, trivial, linux-kernel
On Sun, Jul 06, 2014 at 12:05:53PM +0300, Sami Laine wrote:
> From: Sami Laine <laine.j.sami@gmail.com>
>
> Sparse warning correction:
>
> vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was
> not declared. Should it be static?
>
> Signed-off-by: Sami Laine <laine.j.sami@gmail.com>
> ---
> diff --git a/drivers/staging/rtl8821ae/debug.c b/drivers/staging/rtl8821ae/debug
> index 8aefbf1..e4a19ba 100644
> --- a/drivers/staging/rtl8821ae/debug.c
> +++ b/drivers/staging/rtl8821ae/debug.c
> @@ -77,7 +77,7 @@ void rtl_dbgp_flag_init(struct ieee80211_hw *hw)
> /*Init Debug flag enable condition */
> }
>
> -struct proc_dir_entry *proc_topdir;
> +static struct proc_dir_entry *proc_topdir;
> static int rtl_proc_get_mac_0(struct seq_file *m, void *v)
> {
> struct ieee80211_hw *hw = m->private;
This does not apply properly, and given the lack of testing of your
other patch, I'm loath to try to fix it up by hand myself :(
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-09 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-06 9:05 [PATCH next-20140704]: staging/rtl8821ae/debug.c: sparse warning correction Sami Laine
2014-07-09 19:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox