From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Siva Yerramreddy <yshivakrishna@gmail.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Nikhil Rao <nikhil.rao@intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH char-misc-next v2 2/8] misc: mic: add a bus driver for virtual MIC devices
Date: Wed, 9 Jul 2014 17:42:02 -0700 [thread overview]
Message-ID: <20140710004202.GC4950@kroah.com> (raw)
In-Reply-To: <6e4394a52ccac7bbd16450ace82b2c1a118440e0.1401397315.git.sudeep.dutt@intel.com>
On Thu, May 29, 2014 at 02:23:59PM -0700, Sudeep Dutt wrote:
> +/**
> + * mbus_device - representation of a device using mbus
> + * @priv: private pointer for the driver's use.
> + * @mmio_va: virtual address of mmio space
> + * @hw_ops: the hardware ops supported by this device.
> + * @id: the device type identification (used to match it with a driver).
> + * @dev: underlying device.
> + * be used to communicate with.
> + * @index: unique position on the mbus bus
> + */
> +struct mbus_device {
> + void *priv;
What's wrong with the built-in "private" pointer that struct device has?
That is why it is there...
> + void __iomem *mmio_va;
> + struct mbus_hw_ops *hw_ops;
> + struct mbus_device_id id;
> + struct device dev;
> + int index;
> +};
next prev parent reply other threads:[~2014-07-10 0:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 21:23 [PATCH char-misc-next v2 0/8] Enable dma driver for MIC X100 Coprocessors Sudeep Dutt
2014-05-29 21:23 ` [PATCH char-misc-next v2 1/8] misc: mic: Add mic bus and dma driver documentation Sudeep Dutt
2014-05-29 21:23 ` [PATCH char-misc-next v2 2/8] misc: mic: add a bus driver for virtual MIC devices Sudeep Dutt
2014-07-10 0:42 ` Greg Kroah-Hartman [this message]
2014-07-10 16:43 ` Sudeep Dutt
2014-05-29 21:24 ` [PATCH char-misc-next v2 3/8] dma: MIC X100 DMA Driver Sudeep Dutt
2014-07-10 0:42 ` Greg Kroah-Hartman
2014-05-29 21:24 ` [PATCH char-misc-next v2 4/8] misc: mic: add threaded irq support in host driver Sudeep Dutt
2014-05-29 21:24 ` [PATCH char-misc-next v2 5/8] misc: mic: add dma " Sudeep Dutt
2014-05-29 21:24 ` [PATCH char-misc-next v2 6/8] misc: mic: add threaded irq support in card driver Sudeep Dutt
2014-05-29 21:24 ` [PATCH char-misc-next v2 7/8] misc: mic: add dma " Sudeep Dutt
2014-05-29 21:24 ` [PATCH char-misc-next v2 8/8] misc: mic: add support for loading/unloading dma driver Sudeep Dutt
2014-06-16 15:58 ` [PATCH char-misc-next v2 0/8] Enable dma driver for MIC X100 Coprocessors Sudeep Dutt
2014-06-30 15:33 ` Sudeep Dutt
2014-06-30 16:27 ` Greg Kroah-Hartman
2014-06-30 19:04 ` Sudeep Dutt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710004202.GC4950@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ashutosh.dixit@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.rao@intel.com \
--cc=sudeep.dutt@intel.com \
--cc=yshivakrishna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox