From: Wolfram Sang <wsa@the-dreams.de>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Emil Goode <emilgoode@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jingoo Han <jg1.han@samsung.com>,
Leilei Shang <shangll@marvell.com>,
Peter Korsgaard <peter@korsgaard.com>,
linux-i2c@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc
Date: Thu, 10 Jul 2014 14:02:02 +0200 [thread overview]
Message-ID: <20140710120202.GG2728@katana> (raw)
In-Reply-To: <CAFo99ga3K7JBLCRTQGLYNGT4aX1N9azfjfosvFzoUViMcdMhmQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
> Ok then, Wolfram!
>
> Keep only:
>
> ereqirq:
> clk_disable_unprepare(i2c->clk);
>
> And let everyone else just return?
I haven't looked at the details, but when you simply can return, do it.
> It is rather pointless to add something in a patch, to remove it in the next.
Yup, just say in the patch description that it fixes this bug.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-07-10 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 20:19 [PATCH v3] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc Rickard Strandqvist
2014-07-03 20:19 ` Rickard Strandqvist
2014-07-04 0:02 ` Jingoo Han
2014-07-04 9:10 ` Emil Goode
2014-07-04 17:07 ` Rickard Strandqvist
2014-07-04 17:24 ` Emil Goode
2014-07-05 12:34 ` Rickard Strandqvist
2014-07-10 12:02 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710120202.GG2728@katana \
--to=wsa@the-dreams.de \
--cc=devicetree@vger.kernel.org \
--cc=emilgoode@gmail.com \
--cc=grant.likely@linaro.org \
--cc=jg1.han@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=robh+dt@kernel.org \
--cc=shangll@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox