From: Felipe Balbi <balbi@ti.com>
To: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal
Date: Thu, 10 Jul 2014 08:48:59 -0500 [thread overview]
Message-ID: <20140710134859.GM15340@saruman.home> (raw)
In-Reply-To: <1404436179-10745-5-git-send-email-ttynkkynen@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
Hi,
On Fri, Jul 04, 2014 at 04:09:39AM +0300, Tuomas Tynkkynen wrote:
> tegra_usb_phy_close() is supposed to undo the effects of
> tegra_usb_phy_init(). It is also currently added as the USB PHY shutdown
> callback, which is wrong, since tegra_usb_phy_init() is only called
you could just make tegra_usb_phy_init() be called as u_phy->init().
That way you even delay enabling clocks and regulators to the point
where they are more likely to be needed. Also, if EHCI is never loaded,
you won't power up the PHY for no reason.
> during probing wheras the shutdown callback can get called multiple
> times. This then leads to warnings about unbalanced regulator_disable if
> the EHCI driver is unbound and bound again at runtime.
>
> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
I suppose this has no dependencies with the rest of the series ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-10 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 1:09 [PATCH v2 0/4] Tegra USB probe order issue fix Tuomas Tynkkynen
2014-07-04 1:09 ` [PATCH v2 1/4] USB: tegra: Add resets & has-utmi-pad-registers flag to the PHY binding Tuomas Tynkkynen
2014-07-04 1:09 ` [PATCH v2 2/4] ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs Tuomas Tynkkynen
2014-07-10 15:12 ` Tuomas Tynkkynen
2014-07-14 9:51 ` Thierry Reding
2014-07-04 1:09 ` [PATCH v2 3/4] USB: EHCI: tegra: Fix probe order issue leading to broken USB Tuomas Tynkkynen
2014-07-07 14:16 ` Alan Stern
2014-07-04 1:09 ` [PATCH v2 4/4] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal Tuomas Tynkkynen
2014-07-10 13:48 ` Felipe Balbi [this message]
2014-07-10 14:02 ` Tuomas Tynkkynen
2014-07-04 9:05 ` [PATCH v2 0/4] Tegra USB probe order issue fix Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710134859.GM15340@saruman.home \
--to=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=ttynkkynen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).