From: Greg KH <gregkh@linuxfoundation.org>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "Matwey V. Kornilov" <matwey@sai.msu.ru>,
linux-kernel@vger.kernel.org, linux-parport@lists.infradead.org,
hsommer@eso.org, matwey.kornilov@gmail.com
Subject: Re: [PATCHv3 2/2] Add force_epp module option for parport_pc.
Date: Thu, 10 Jul 2014 10:08:13 -0700 [thread overview]
Message-ID: <20140710170813.GA23544@kroah.com> (raw)
In-Reply-To: <20140710165225.0991f478@alan.etchedpixels.co.uk>
On Thu, Jul 10, 2014 at 04:52:25PM +0100, One Thousand Gnomes wrote:
> > module parameters are horrid, how is someone supposed to know to use
> > this? Why can't we "fix" the detection logic? You just now broke
> > systems that were working by forcing them to now set a module option
> > where previously they didn't, so I can't take these patches as-is,
> > sorry.
>
> Can we not just add "if the CPU is PPro or higher than all is fine" ? to
> the test ?
That sounds reasonable to me.
greg k-h
prev parent reply other threads:[~2014-07-10 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 7:01 [PATCHv3 2/2] Add force_epp module option for parport_pc Matwey V. Kornilov
2014-07-09 21:29 ` Greg KH
2014-07-10 7:56 ` Matwey V. Kornilov
2014-07-10 14:11 ` Dave Jones
2014-07-10 15:50 ` Matwey V. Kornilov
2014-07-10 17:09 ` Greg KH
2014-07-10 17:32 ` Matwey V. Kornilov
2014-07-10 17:43 ` Greg KH
2014-07-11 6:39 ` Matwey V. Kornilov
2014-07-10 21:48 ` [Linux-parport] " Leopold Palomo-Avellaneda
2014-07-11 14:12 ` Matwey V. Kornilov
2014-07-10 15:52 ` One Thousand Gnomes
2014-07-10 17:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710170813.GA23544@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=hsommer@eso.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=matwey.kornilov@gmail.com \
--cc=matwey@sai.msu.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox