From: Andrew Morton <akpm@linux-foundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Wim Van Sebroeck <wim@iguana.be>,
Catalin Marinas <catalin.marinas@arm.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
Heiko Stuebner <heiko@sntech.de>,
Russell King <linux@arm.linux.org.uk>,
Jonas Jensen <jonas.jensen@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Tomasz Figa <t.figa@samsung.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] kernel: Add support for restart notifier call chain
Date: Thu, 10 Jul 2014 17:44:25 -0700 [thread overview]
Message-ID: <20140710174425.2f3fea98.akpm@linux-foundation.org> (raw)
In-Reply-To: <53BF2CB5.5080602@roeck-us.net>
On Thu, 10 Jul 2014 17:15:49 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
> Error on my part - I thought lower numbers would
> have higher priority, but after looking into the code again that
> is wrong.
You shouldn't have needed to look into the code :( Maybe a
documentation patch for notifier_block.priority for the next person?
> To avoid making things too complicated, maybe it would make sense to
> specify guidelines for notifier priorities, such as
> 0 - restart notifier of last resort, with least reset capabilities
> 128 - default; use if no other notifier is expected to be available
> and/or if restart functionality is acceptable
> 255 - highest priority notifier which _must_ be used
>
> Would that make sense and be acceptable ? In this context, I would then
> set the notifier priorities for the callers in the patch set to 128.
Yep, that sounds nice. It's unlikely to see a lot of use, but at least
we showed we thought about it ;)
prev parent reply other threads:[~2014-07-11 0:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 3:37 [PATCH v3 0/7] kernel: Add support for restart notifier call chain Guenter Roeck
2014-07-09 3:37 ` [PATCH v3 1/7] " Guenter Roeck
2014-07-09 3:37 ` [PATCH v3 2/7] arm64: Support restart through " Guenter Roeck
2014-07-09 3:37 ` [PATCH v3 3/7] arm: " Guenter Roeck
2014-07-09 3:38 ` [PATCH v3 4/7] power/restart: Call machine_restart instead of arm_pm_restart Guenter Roeck
2014-07-09 3:38 ` [PATCH v3 5/7] watchdog: moxart: Register restart handler with restart notifier Guenter Roeck
2014-07-09 3:38 ` [PATCH v3 6/7] watchdog: alim7101: " Guenter Roeck
2014-07-09 3:38 ` [PATCH v3 7/7] arm/arm64: Unexport restart handlers Guenter Roeck
2014-07-10 23:09 ` [PATCH v3 0/7] kernel: Add support for restart notifier call chain Andrew Morton
2014-07-11 0:15 ` Guenter Roeck
2014-07-11 0:44 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710174425.2f3fea98.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=heiko@sntech.de \
--cc=jonas.jensen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=maxime.ripard@free-electrons.com \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=t.figa@samsung.com \
--cc=will.deacon@arm.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox