From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193AbaGJUeA (ORCPT ); Thu, 10 Jul 2014 16:34:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59059 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbaGJUd7 (ORCPT ); Thu, 10 Jul 2014 16:33:59 -0400 Date: Thu, 10 Jul 2014 13:38:25 -0700 From: Greg Kroah-Hartman To: Kees Cook Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, "John W. Linville" Subject: Re: [PATCH] staging: r8821ae: avoid leaking format string Message-ID: <20140710203825.GA31985@kroah.com> References: <20140710201611.GA31972@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140710201611.GA31972@www.outflux.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 10, 2014 at 01:16:11PM -0700, Kees Cook wrote: > This make sure a format string cannot leak into the work queue name nor > the printk buffer. > > Signed-off-by: Kees Cook > --- > This is the third time this set of macros has entered the kernel: > > drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h > drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.h > drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.h > > Can we extract these macros to some common place and keep them from returning? I wish. These are all from the same company. Each new version of their hardware consists of a whole dump of a wireless stack. People are working on addressing this issue, by writing "real" drivers for the hardware, and working with the company to not keep doing this. But odds are, I'll get a new driver for the next chip from them that does the same thing :( thanks for the patch, I'll queue it up. greg k-h