Re: [PATCH 11/13] [RFC] mmc: tmio-mmc: Add support for SDHI on new R-Car Gen2 SoCs

Simon Horman
2014-07-11T14:23:08Z

On Wed, Jul 09, 2014 at 02:23:41PM +0200, Geert Uytterhoeven wrote:
> - r8a7792 (R-Car V2H)
> - r8a7793 (R-Car M2-N)
> - r8a7794 (R-Car E2)
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

This seems to be in keeping with the approach we ave taken for these
SoCs for other drivers. And from that point of view it is fine by me.
But I wonder how sure are we that the hardware on the SoCs will work
with this approach.

> ---
> Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 3 +++
> drivers/mmc/host/sh_mobile_sdhi.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> index fa0f327cde01..400b640fabc7 100644
> --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> @@ -19,6 +19,9 @@ Required properties:
> "renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
> "renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
> "renesas,sdhi-r8a7791" - SDHI IP on R8A7791 SoC
> + "renesas,sdhi-r8a7792" - SDHI IP on R8A7792 SoC
> + "renesas,sdhi-r8a7793" - SDHI IP on R8A7793 SoC
> + "renesas,sdhi-r8a7794" - SDHI IP on R8A7794 SoC
>
> Optional properties:
> - toshiba,mmc-wrprotect-disable: write-protect detection is unavailable
> diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> index 91058dabd11a..443c20969bd7 100644
> --- a/drivers/mmc/host/sh_mobile_sdhi.c
> +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> @@ -68,6 +68,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = {
> { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
> { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7791", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7792", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7793", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7794", .data = &of_rcar_gen2_compatible, },
> {},
> };
> MODULE_DEVICE_TABLE(of, sh_mobile_sdhi_of_match);
> --
> 1.9.1
>