From: Frederic Weisbecker <fweisbec@gmail.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux.com>,
Kevin Hilman <khilman@linaro.org>,
Mike Galbraith <bitbucket@online.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Tejun Heo <tj@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [RFC PATCH 0/5] workqueue: Introduce low-level unbound wq sysfs cpumask v3
Date: Fri, 11 Jul 2014 15:11:59 +0200 [thread overview]
Message-ID: <20140711131155.GA26045@localhost.localdomain> (raw)
In-Reply-To: <53BFA34F.9010800@cn.fujitsu.com>
On Fri, Jul 11, 2014 at 04:41:51PM +0800, Lai Jiangshan wrote:
> Hi, Frederic
>
> I'd like to take this work unless you are still working on it.
> I would do some cleanup at first so that it will be much slow for me.
Hi Lai,
I was about to iterate again on that patchset but I would certainly be
happy if you take it given the amount of stuff in my TODO list.
I suggest you to take this branch:
git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
core/workqueue-v6
It's a big rebase on top of latest -rc1.
Also I suggest you to use "--patience" on git diff/log/format-patch etc...
because the changes contain big code move (like the sysfs part) that default
diff doesn't display well.
I can still help you on this patchset BTW if you need. I believe that
delayed workqueues weren't well handled with it, maybe I should
check further if they need some more treatment.
Thanks.
>
> Thanks,
> Lai
>
>
> On 05/17/2014 12:16 AM, Frederic Weisbecker wrote:
> > So in this version I actually save the cpumask belonging to wq (before
> > it's intersected against the low level cpumask) in its unbounds attrs.
> >
> > But the attrs passed to pwq and worker pools have the low level cpumask
> > computed against the wq cpumask.
> >
> > It makes it easier that way as the wq cpumask itself remains untouched.
> > It's a user setting so it must stay intact. OTOH the cpumask of pwqs and
> > worker pools only belong to the implementation so it's the right
> > place to store the effective cpumask.
> >
> > Also wq_update_unbound_numa() is fixed, and cpu_possible_mask()
> > is restored as a base. Thanks to Lai!
> >
> > Thanks,
> > Frederic
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> > core/workqueue-v5
> > ---
> >
> > Frederic Weisbecker (4):
> > workqueue: Reorder sysfs code
> > workqueue: Create low-level unbound workqueues cpumask
> > workqueue: Split apply attrs code from its locking
> > workqueue: Allow modifying low level unbound workqueue cpumask
> >
> > Lai Jiangshan (1):
> > workqueue: Allow changing attributions of ordered workqueues
> >
> >
> > kernel/workqueue.c | 1674 ++++++++++++++++++++++++++++------------------------
> > 1 file changed, 900 insertions(+), 774 deletions(-)
> > .
> >
>
prev parent reply other threads:[~2014-07-11 13:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 16:16 [RFC PATCH 0/5] workqueue: Introduce low-level unbound wq sysfs cpumask v3 Frederic Weisbecker
2014-05-16 16:16 ` [PATCH 1/5] workqueue: Allow changing attributions of ordered workqueues Frederic Weisbecker
2014-05-16 20:12 ` Tejun Heo
2014-05-17 13:41 ` Frederic Weisbecker
2014-05-19 20:15 ` Tejun Heo
2014-05-20 14:32 ` Frederic Weisbecker
2014-05-20 14:35 ` Tejun Heo
2014-05-20 15:08 ` Frederic Weisbecker
2014-05-21 7:29 ` Lai Jiangshan
2014-05-21 19:18 ` Tejun Heo
2014-05-16 16:16 ` [PATCH 2/5] workqueue: Reorder sysfs code Frederic Weisbecker
2014-05-16 16:16 ` [PATCH 3/5] workqueue: Create low-level unbound workqueues cpumask Frederic Weisbecker
2014-05-16 17:52 ` Christoph Lameter
2014-05-16 18:35 ` Tejun Heo
2014-05-16 18:52 ` Christoph Lameter
2014-05-16 19:00 ` Tejun Heo
2014-05-16 19:22 ` Tejun Heo
2014-05-16 19:32 ` Christoph Lameter
2014-05-16 19:34 ` Tejun Heo
2014-05-16 19:45 ` Tejun Heo
2014-05-16 23:02 ` Christoph Lameter
2014-05-16 23:48 ` Tejun Heo
2014-05-17 22:45 ` Christoph Lameter
2014-05-18 2:51 ` Tejun Heo
2014-05-16 16:16 ` [PATCH 4/5] workqueue: Split apply attrs code from its locking Frederic Weisbecker
2014-05-16 16:16 ` [PATCH 5/5] workqueue: Allow modifying low level unbound workqueue cpumask Frederic Weisbecker
2014-05-16 20:50 ` Tejun Heo
2014-05-20 19:32 ` Frederic Weisbecker
2014-05-20 19:56 ` Tejun Heo
2014-05-20 20:08 ` Frederic Weisbecker
2014-07-11 8:41 ` [RFC PATCH 0/5] workqueue: Introduce low-level unbound wq sysfs cpumask v3 Lai Jiangshan
2014-07-11 13:11 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711131155.GA26045@localhost.localdomain \
--to=fweisbec@gmail.com \
--cc=bitbucket@online.de \
--cc=cl@linux.com \
--cc=khilman@linaro.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox