From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: konrad@kernel.org, xen-devel@lists.xenproject.org,
david.vrabel@citrix.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/5] xen/pciback: Don't deadlock when unbinding.
Date: Fri, 11 Jul 2014 17:02:01 -0400 [thread overview]
Message-ID: <20140711210201.GC25233@laptop.dumpdata.com> (raw)
In-Reply-To: <53C04D81.3010002@oracle.com>
> >--- a/drivers/xen/xen-pciback/pci_stub.c
> >+++ b/drivers/xen/xen-pciback/pci_stub.c
> >@@ -250,6 +250,8 @@ struct pci_dev *pcistub_get_pci_dev(struct xen_pcibk_device *pdev,
> > * - 'echo BDF > unbind' with a guest still using it. See pcistub_remove
> > *
> > * As such we have to be careful.
> >+ *
> >+ * To make this easier, the caller has to hold the device lock.
>
> Should we assert that the lock is being held?
Yes of course we should. Thank you!
next prev parent reply other threads:[~2014-07-11 21:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 20:08 [PATCH v4] PCI back fixes for 3.17 konrad
2014-07-11 20:08 ` [PATCH v4 1/5] xen-pciback: Document the various parameters and attributes in SysFS konrad
2014-07-11 20:46 ` Boris Ostrovsky
2014-07-14 16:28 ` Konrad Rzeszutek Wilk
2014-07-11 20:08 ` [PATCH v4 2/5] xen/pciback: Don't deadlock when unbinding konrad
2014-07-11 20:48 ` Boris Ostrovsky
2014-07-11 21:02 ` Konrad Rzeszutek Wilk [this message]
2014-07-14 14:13 ` Konrad Rzeszutek Wilk
2014-07-14 14:30 ` Boris Ostrovsky
2014-07-14 15:42 ` Konrad Rzeszutek Wilk
2014-07-11 20:08 ` [PATCH v4 3/5] xen/pciback: Include the domain id if removing the device whilst still in use konrad
2014-07-11 20:08 ` [PATCH v4 4/5] xen/pciback: Print out the domain owning the device konrad
2014-07-11 20:08 ` [PATCH v4 5/5] xen/pciback: Remove tons of dereferences konrad
2014-07-11 20:54 ` Boris Ostrovsky
2014-07-14 16:37 ` [Xen-devel] [PATCH v4] PCI back fixes for 3.17 Sander Eikelenboom
2014-07-14 17:22 ` Konrad Rzeszutek Wilk
2014-07-14 17:29 ` Sander Eikelenboom
2014-07-14 17:37 ` Konrad Rzeszutek Wilk
2014-07-14 17:43 ` Sander Eikelenboom
2014-07-14 17:45 ` Konrad Rzeszutek Wilk
2014-07-14 18:24 ` Sander Eikelenboom
2014-07-14 18:45 ` Konrad Rzeszutek Wilk
2014-07-14 19:01 ` Sander Eikelenboom
2014-07-14 19:50 ` Sander Eikelenboom
2014-07-14 19:54 ` Konrad Rzeszutek Wilk
2014-07-14 20:16 ` Sander Eikelenboom
2014-07-14 20:18 ` Konrad Rzeszutek Wilk
2014-07-14 20:21 ` Sander Eikelenboom
2014-07-14 20:25 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711210201.GC25233@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox