From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jiri Slaby <jslaby@suse.cz>,
julia.lawall@lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drivers: tty: Merge alloc_tty_struct and initialize_tty_struct
Date: Sat, 12 Jul 2014 09:47:14 -0700 [thread overview]
Message-ID: <20140712164714.GA12148@kroah.com> (raw)
In-Reply-To: <20140712121613.GY23001@mwanda>
On Sat, Jul 12, 2014 at 03:16:13PM +0300, Dan Carpenter wrote:
> On Sat, Jul 12, 2014 at 12:55:51PM +0200, Rasmus Villemoes wrote:
> > The two functions alloc_tty_struct and initialize_tty_struct are
> > always called together. Merge them into alloc_tty_struct, updating its
> > prototype and the only two callers of these functions.
> >
> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > ---
> > I hope this is sufficient. Thanks, Dan and Julia!
>
> Generally Greg's trees can't be rebased. I think you need to send a fix
> patch.
That is correct. Rasmus, please just send a patch on top of my tree
that resolves this issue.
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-12 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 16:16 [PATCH] drivers: tty: Remove redundant memset() in initialize_tty_struct Rasmus Villemoes
2014-07-10 16:22 ` Jiri Slaby
2014-07-10 19:01 ` [PATCH] drivers: tty: Merge alloc_tty_struct and initialize_tty_struct Rasmus Villemoes
2014-07-12 10:55 ` [PATCH v2] " Rasmus Villemoes
2014-07-12 12:16 ` Dan Carpenter
2014-07-12 16:47 ` Greg Kroah-Hartman [this message]
2014-07-12 23:44 ` [PATCH] drivers: tty: Fix use-after-free in pty_common_install Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140712164714.GA12148@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=jslaby@suse.cz \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox