public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lucas Tanure <tanure@linux.com>
Cc: "Arve Hjønnevåg" <arve@android.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply
Date: Sun, 13 Jul 2014 12:07:19 -0700	[thread overview]
Message-ID: <20140713190719.GA31809@kroah.com> (raw)
In-Reply-To: <20140713144929.GA6656@archDesk>

On Sun, Jul 13, 2014 at 11:49:29AM -0300, Lucas Tanure wrote:
> Kernel coding style. Remove useless else statement after return.
> 
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
>  drivers/staging/android/binder.c | 27 +++++++++++++--------------
>  1 file changed, 13 insertions(+), 14 deletions(-)

You didn't compile this patch :(

Or if you did, you ignored the fact that it now adds a warning to the
kernel build process, which is not allowed.  Please fix this up and
resend.

thanks,

greg k-h

  parent reply	other threads:[~2014-07-13 19:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-13 14:49 [RESEND PATCH] staging: android: Clean up binder_send_failed_reply Lucas Tanure
2014-07-13 16:30 ` Greg Kroah-Hartman
2014-07-13 16:38   ` Lucas Tanure
2014-07-13 16:44     ` Greg Kroah-Hartman
2014-07-13 19:07 ` Greg Kroah-Hartman [this message]
2014-07-13 19:48   ` Lucas Tanure

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140713190719.GA31809@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tanure@linux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox