From: Dan Carpenter <dan.carpenter@oracle.com>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: Jeremiah Mahler <jmmahler@gmail.com>,
devel@driverdev.osuosl.org, Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] xillybus: place 'else' on same line as '}'
Date: Mon, 14 Jul 2014 11:51:42 +0300 [thread overview]
Message-ID: <20140714085142.GK25880@mwanda> (raw)
In-Reply-To: <53C37B67.7000203@gmail.com>
On Mon, Jul 14, 2014 at 09:40:39AM +0300, Eli Billauer wrote:
> Hi,
>
> Thanks for this.
>
> And since I looked at the part in Codingstyle that deals with
> if-else, I found another few mistakes regarding braces around a
> single statement. The rules say, it turns out, that if one of the
> clauses in an if-else is longer than one statement, both clauses
> should be wrapped with braces. This rule is broken in lines 162, 536
> and 613 of the same file.
>
> To avoid possible conflicts, I'll wait for this patch to be applied,
> and submit my corrections after that.
In theory there shouldn't be any need to wait because the rules about
which patches go in first are very clear and predictable. First come
first serve. Unless a patch is rejected. And they are only rejected if
they violate some rule, but normally ok patches go in.
This patch is almost totally ok except it doesn't have "staging" in the
subject. I'm not sure if that's enough to reject it... Probably it's
ok and you should assume it will be merged.
The other reason that you don't need to wait is that this patch won't
conflict with the other patch you are proposing.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-14 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 3:07 [PATCH] xillybus: place 'else' on same line as '}' Jeremiah Mahler
2014-07-14 6:40 ` Eli Billauer
2014-07-14 8:51 ` Dan Carpenter [this message]
2014-07-14 16:08 ` Jeremiah Mahler
2014-07-14 16:02 ` Jeremiah Mahler
2014-07-18 0:18 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714085142.GK25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=eli.billauer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmmahler@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox