From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Nicolas Del Piano <ndel314@gmail.com>
Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP
Date: Mon, 14 Jul 2014 09:43:36 -0300 [thread overview]
Message-ID: <20140714124336.GA1763@arch.cereza> (raw)
In-Reply-To: <1405288740-3986-1-git-send-email-ndel314@gmail.com>
Nico,
On 13 Jul 06:59 PM, Nicolas Del Piano wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
>
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>
Thanks for the patch. I have just a very minor nitpick to comment;
if you run a git log, you'll see the subject should be:
"cpufreq: imx6q: Select PM_OPP"
In general, it's better to see the recent commits to find out how to write
the commit title; each driver can have its own style.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2014-07-14 12:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 21:59 [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP Nicolas Del Piano
2014-07-14 4:10 ` Viresh Kumar
2014-07-14 12:43 ` Ezequiel Garcia [this message]
2014-07-14 13:29 ` Nicolas Del Piano
2014-07-18 1:04 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714124336.GA1763@arch.cereza \
--to=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ndel314@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox