public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Joerg C. Meyer" <joerg@meyer.homedns.org>
Cc: dingtianhong@huawei.com, chenweilong@huawei.com,
	sachin.kamat@linaro.org, davem@davemloft.net,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8821ae: fix coding style issue in cam.c
Date: Mon, 14 Jul 2014 06:26:33 -0700	[thread overview]
Message-ID: <20140714132633.GA8144@kroah.com> (raw)
In-Reply-To: <1405330953-20279-1-git-send-email-joerg@meyer.homedns.org>

On Mon, Jul 14, 2014 at 11:42:33AM +0200, Joerg C. Meyer wrote:
> This is a patch to the cam.c file that fix a coding style error (do not use C99 // comments)
> Signed-off-by: Joerg C. Meyer <joerg@meyer.homedns.org>

Minor nit, you need a blank line between these two lines...

> ---
>  drivers/staging/rtl8821ae/cam.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c
> index 3bc6b3d..9c0cd1e 100644
> --- a/drivers/staging/rtl8821ae/cam.c
> +++ b/drivers/staging/rtl8821ae/cam.c
> @@ -152,7 +152,7 @@ u8 rtl_cam_add_one_entry(struct ieee80211_hw *hw, u8 *mac_addr,
>  	return 1;
>  
>  }
> -//EXPORT_SYMBOL(rtl_cam_add_one_entry);
> +/* EXPORT_SYMBOL(rtl_cam_add_one_entry); */

Your patch is correct, but how about just deleting these lines instead?
They aren't needed, so please remove them.

Can you do that and resend?

thanks,

greg k-h

      reply	other threads:[~2014-07-14 13:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14  9:42 [PATCH] Staging: rtl8821ae: fix coding style issue in cam.c Joerg C. Meyer
2014-07-14 13:26 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714132633.GA8144@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chenweilong@huawei.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=dingtianhong@huawei.com \
    --cc=joerg@meyer.homedns.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox