From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, tvboxspy@gmail.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
forest@alittletooquiet.net
Subject: Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues
Date: Mon, 14 Jul 2014 17:12:31 +0300 [thread overview]
Message-ID: <20140714141231.GM25880@mwanda> (raw)
In-Reply-To: <20140714085932.GA2958@hp-peter.rsr.lip6.fr>
Since you're going to redo this patch anyway, I may as well give you
the normal feedback for these kinds of patches.
> >From 69cd87aca39730c0578592d1296b738f7f223f29 Mon Sep 17 00:00:00 2001
> From: Peter Senna Tschudin <peter.senna@gmail.com>
> Date: Mon, 14 Jul 2014 10:28:42 +0200
> Subject: [PATCH V3] staging: vt6556: Cleanup coding style issues
>
> This patch cleanup coding style issues reported by checkpatch.
>
> This typedef, reported by checkpatch, was removed from card.h:
> typedef enum _CARD_PHY_TYPE {
> PHY_TYPE_AUTO = 0,
> PHY_TYPE_11B,
> PHY_TYPE_11G,
> PHY_TYPE_11A
> } CARD_PHY_TYPE, *PCARD_PHY_TYPE;
>
> The following typedefs were removed, but enums were kept at device.h:
> - typedef enum __device_msg_level
> - typedef enum __DEVICE_NDIS_STATUS
>
Break this kind of patch into patches which fix one type of mistake per
patch:
patch 1: fix whitespace stuff
patch 2: remove useless returns
patch 3: remove typedefs
etc.
> -//{{RobertYu:20060515, new BB setting for VT3226D0
> +/* {{RobertYu:20060515, new BB setting for VT3226D0 */
Just delete these, because we have version control.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-14 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 19:11 [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues Peter Senna Tschudin
2014-07-13 19:11 ` [PATCH V2 2/4] " Peter Senna Tschudin
2014-07-13 19:11 ` [PATCH V2 3/4] " Peter Senna Tschudin
2014-07-13 19:11 ` [PATCH V2 4/4] " Peter Senna Tschudin
2014-07-13 19:36 ` [PATCH V2 1/4] " Greg KH
2014-07-14 8:59 ` Peter Senna Tschudin
2014-07-14 12:58 ` Greg KH
2014-07-14 14:03 ` Peter Senna Tschudin
2014-07-14 14:12 ` Dan Carpenter [this message]
2014-07-14 17:01 ` Peter Senna Tschudin
2014-07-14 17:09 ` Dan Carpenter
2014-07-14 17:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714141231.GM25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox