From: Andi Kleen <ak@linux.intel.com>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
Miklos Szeredi <mszeredi@suse.cz>
Subject: Re: [PATCH] vfs: Turn the unlinked inode counter into a percpu counter
Date: Mon, 14 Jul 2014 08:49:30 -0700 [thread overview]
Message-ID: <20140714154930.GB5803@tassilo.jf.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1407141022580.13527@localhost.localdomain>
> > diff --git a/fs/inode.c b/fs/inode.c
> > index f96d2a6..4820c35 100644
> > --- a/fs/inode.c
> > +++ b/fs/inode.c
> > @@ -234,10 +234,8 @@ void __destroy_inode(struct inode *inode)
> > BUG_ON(inode_has_buffers(inode));
> > security_inode_free(inode);
> > fsnotify_inode_delete(inode);
> > - if (!inode->i_nlink) {
> > - WARN_ON(atomic_long_read(&inode->i_sb->s_remove_count) == 0);
>
> This is not mentioned in the description, but I guess it makes sense since
> it'd be quite expensive.
Yes. I guess we could still check the local counter. I can re-add that.
-Andi
next prev parent reply other threads:[~2014-07-14 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 20:23 [PATCH] vfs: Turn the unlinked inode counter into a percpu counter Andi Kleen
2014-07-14 8:26 ` Lukáš Czerner
2014-07-14 15:49 ` Andi Kleen [this message]
2014-07-14 15:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714154930.GB5803@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mszeredi@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox