From: Jeremiah Mahler <jmmahler@gmail.com>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xillybus: place 'else' on same line as '}'
Date: Mon, 14 Jul 2014 09:02:18 -0700 [thread overview]
Message-ID: <20140714160218.GA18975@hudson.localdomain> (raw)
In-Reply-To: <53C37B67.7000203@gmail.com>
Eli,
On Mon, Jul 14, 2014 at 09:40:39AM +0300, Eli Billauer wrote:
> Hi,
>
> Thanks for this.
>
> And since I looked at the part in Codingstyle that deals with if-else, I
> found another few mistakes regarding braces around a single statement. The
> rules say, it turns out, that if one of the clauses in an if-else is longer
> than one statement, both clauses should be wrapped with braces. This rule is
> broken in lines 162, 536 and 613 of the same file.
>
I just looked through CodingStyle, and you are right. If braces are
used on one branch they should be used on all branches.
Interestingly, checkpatch.pl doesn't warn about these.
> ...
Cheers,
--
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler
next prev parent reply other threads:[~2014-07-14 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 3:07 [PATCH] xillybus: place 'else' on same line as '}' Jeremiah Mahler
2014-07-14 6:40 ` Eli Billauer
2014-07-14 8:51 ` Dan Carpenter
2014-07-14 16:08 ` Jeremiah Mahler
2014-07-14 16:02 ` Jeremiah Mahler [this message]
2014-07-18 0:18 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714160218.GA18975@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=eli.billauer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox