public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	Ingo Molnar <mingo@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	LAK <linux-arm-kernel@lists.infradead.org>,
	Preeti U Murthy <preeti@linux.vnet.ibm.com>,
	Mike Galbraith <efault@gmx.de>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Dietmar Eggemann <Dietmar.Eggemann@arm.com>
Subject: Re: [PATCH v3 09/12] Revert "sched: Put rq's sched_avg under CONFIG_FAIR_GROUP_SCHED"
Date: Mon, 14 Jul 2014 18:22:49 +0200	[thread overview]
Message-ID: <20140714162249.GE9918@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140714140435.GO26542@e103034-lin>

[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]

On Mon, Jul 14, 2014 at 03:04:35PM +0100, Morten Rasmussen wrote:
> > I'm struggling to fully grasp your intent. We need DVFS like accounting
> > for sure, and that means a current freq hook, but I'm not entirely sure
> > how that relates to capacity.
> 
> We can abstract all the factors that affect current compute capacity
> (frequency, P-states, big.LITTLE,...) in the scheduler by having
> something like capacity_{cur,avail} to tell us how much capacity does a
> particular cpu have in its current state. Assuming that implement scale
> invariance for entity load tracking (we are working on that), we can
> directly compare task utilization with compute capacity for balancing
> decisions. For example, we can figure out how much spare capacity a cpu
> has in its current state by simply:
> 
> spare_capacity(cpu) = capacity_avail(cpu) - \sum_{tasks(cpu)}^{t} util(t)
> 
> If you put more than spare_capacity(cpu) worth of task utilization on
> the cpu, you will cause the cpu (and any affected cpus) to change
> P-state and potentially be less energy-efficient.
> 
> Does that make any sense?
> 
> Instead of dealing with frequencies directly in the scheduler code, we
> can abstract it by just having scalable compute capacity.

Ah, ok. Same thing then.

> > But yes, for application the tipping point is u == 1, up until that
> > point pure utilization makes sense, after that our runnable_avg makes
> > more sense.
> 
> Agreed.
> 
> If you really care about latency/performance you might be interested in
> comparing running_avg and runnable_avg even for u < 1. If the
> running_avg/runnable_avg ratio is significantly less than one, tasks are
> waiting on the rq to be scheduled.

Indeed, that gives a measure of queueing.

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-07-14 16:23 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 16:05 [PATCH v3 00/12] sched: consolidation of cpu_power Vincent Guittot
2014-06-30 16:05 ` [PATCH v3 01/12] sched: fix imbalance flag reset Vincent Guittot
2014-07-08  3:13   ` Preeti U Murthy
2014-07-08 10:12     ` Vincent Guittot
2014-07-09  3:54       ` Preeti U Murthy
2014-07-09  8:27         ` Vincent Guittot
2014-07-09 10:43         ` Peter Zijlstra
2014-07-09 11:41           ` Preeti U Murthy
2014-07-09 14:44             ` Peter Zijlstra
2014-07-10  9:14           ` Vincent Guittot
2014-07-10  9:30             ` [PATCH v4 ] " Vincent Guittot
2014-07-10 10:57               ` Preeti U Murthy
2014-07-10 11:04             ` [PATCH v3 01/12] " Preeti U Murthy
2014-07-09  3:05   ` Rik van Riel
2014-07-09  3:36     ` Rik van Riel
2014-07-09 10:14   ` Peter Zijlstra
2014-07-09 10:30     ` Vincent Guittot
2014-06-30 16:05 ` [PATCH v3 02/12] sched: remove a wake_affine condition Vincent Guittot
2014-07-09  3:06   ` Rik van Riel
2014-06-30 16:05 ` [PATCH v3 03/12] sched: fix avg_load computation Vincent Guittot
2014-07-09  3:10   ` Rik van Riel
2014-06-30 16:05 ` [PATCH v3 04/12] sched: Allow all archs to set the power_orig Vincent Guittot
2014-07-09  3:11   ` Rik van Riel
2014-07-09 10:57   ` Peter Zijlstra
2014-07-10 13:42     ` Vincent Guittot
2014-06-30 16:05 ` [PATCH v3 05/12] ARM: topology: use new cpu_power interface Vincent Guittot
2014-07-09  3:11   ` Rik van Riel
2014-07-09  7:49   ` Amit Kucheria
2014-07-09 10:09     ` Vincent Guittot
2014-06-30 16:05 ` [PATCH v3 06/12] sched: add per rq cpu_power_orig Vincent Guittot
2014-07-09  3:11   ` Rik van Riel
2014-07-09  7:50   ` Amit Kucheria
2014-06-30 16:05 ` [PATCH v3 07/12] sched: test the cpu's capacity in wake affine Vincent Guittot
2014-07-09  3:12   ` Rik van Riel
2014-07-10 11:06   ` Peter Zijlstra
2014-07-10 13:58     ` Vincent Guittot
2014-06-30 16:05 ` [PATCH v3 08/12] sched: move cfs task on a CPU with higher capacity Vincent Guittot
2014-07-10 11:18   ` Peter Zijlstra
2014-07-10 14:03     ` Vincent Guittot
2014-07-11 14:51       ` Peter Zijlstra
2014-07-11 15:17         ` Vincent Guittot
2014-07-14 13:51           ` Peter Zijlstra
2014-07-15  9:21             ` Vincent Guittot
2014-07-10 11:24   ` Peter Zijlstra
2014-07-10 13:59     ` Vincent Guittot
2014-07-10 11:31   ` Peter Zijlstra
2014-06-30 16:05 ` [PATCH v3 09/12] Revert "sched: Put rq's sched_avg under CONFIG_FAIR_GROUP_SCHED" Vincent Guittot
2014-07-10 13:16   ` Peter Zijlstra
2014-07-11  7:51     ` Vincent Guittot
2014-07-11 15:13       ` Peter Zijlstra
2014-07-11 17:39         ` Vincent Guittot
2014-07-11 20:12           ` Peter Zijlstra
2014-07-14 12:55             ` Morten Rasmussen
2014-07-14 13:20               ` Peter Zijlstra
2014-07-14 14:04                 ` Morten Rasmussen
2014-07-14 16:22                   ` Peter Zijlstra [this message]
2014-07-15  9:20             ` Vincent Guittot
2014-07-14 17:54           ` Dietmar Eggemann
2014-07-18  1:27             ` Yuyang Du
2014-07-11 16:13       ` Morten Rasmussen
2014-07-15  9:27         ` Vincent Guittot
2014-07-15  9:32           ` Morten Rasmussen
2014-07-15  9:53             ` Vincent Guittot
2014-06-30 16:05 ` [PATCH v3 10/12] sched: get CPU's utilization statistic Vincent Guittot
2014-06-30 16:05 ` [PATCH v3 11/12] sched: replace capacity_factor by utilization Vincent Guittot
2014-06-30 16:05 ` [PATCH v3 12/12] sched: add SD_PREFER_SIBLING for SMT level Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714162249.GE9918@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=Dietmar.Eggemann@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=efault@gmx.de \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@kernel.org \
    --cc=morten.rasmussen@arm.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox