From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andy Lutomirski <luto@amacapital.net>, david.vrabel@citrix.com
Cc: "H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Is espfix64's double-fault thing OK on Xen?
Date: Mon, 14 Jul 2014 12:58:35 -0400 [thread overview]
Message-ID: <20140714165835.GA9969@laptop.dumpdata.com> (raw)
In-Reply-To: <CALCETrXrVNKNQtxncfOth5OqaSOC7KygerbB-+QQb4_VKESVsA@mail.gmail.com>
On Wed, Jul 09, 2014 at 04:17:57PM -0700, Andy Lutomirski wrote:
> This part in __do_double_fault looks fishy:
>
> cmpl $__KERNEL_CS,CS(%rdi)
> jne do_double_fault
>
> Shouldn't that be:
>
> test $3,CS(%rdi)
> jnz do_double_fault
>
Let me rope in David, who was playing with that recently.
> --Andy
next prev parent reply other threads:[~2014-07-14 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 23:17 Is espfix64's double-fault thing OK on Xen? Andy Lutomirski
2014-07-14 16:58 ` Konrad Rzeszutek Wilk [this message]
2014-07-14 17:04 ` H. Peter Anvin
2014-07-14 17:11 ` Andy Lutomirski
2014-07-14 17:15 ` Andy Lutomirski
2014-07-14 21:31 ` Andy Lutomirski
2014-07-14 21:35 ` Andy Lutomirski
2014-07-14 22:23 ` H. Peter Anvin
2014-07-15 2:46 ` Andy Lutomirski
2014-07-15 3:20 ` Andy Lutomirski
2014-07-15 4:14 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714165835.GA9969@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox