public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: konrad@kernel.org, xen-devel@lists.xenproject.org,
	boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
	linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH v4] PCI back fixes for 3.17.
Date: Mon, 14 Jul 2014 16:25:31 -0400	[thread overview]
Message-ID: <20140714202531.GA24877@laptop.dumpdata.com> (raw)
In-Reply-To: <1174271881.20140714222152@eikelenboom.it>

> >> > Thank you for reporting it and helping me with the XenStore output to
> >> > narrow down the culprit!
> >> 
> >> The thing i don't understand then is:
> >> How is it different for the last (or all ) device(s) ?
> >> (since the last device (or removing all devices) before doing the 
> >> assignable-remove doesn't trigger the warning)
> >> 
> >> Or does the complete removal of the pci-part of the tree in xenstore trigger something ?
> 
> > Yup. It removes the whole 'pci' directory in XenStore which triggers
> > in Xen pciback the code to deal with that.
> So that essentially needs to be changed to watch the individual devices in the 
> xenstore tree instead of the whole pci stuff.

Correct. Thought instead of watching it will just compare with what it
had assigned to a guest and what it currently has exposed in XenStore. And
then whatever is not on the list (exposed in XenStore) is going to be reaped.

> Then it all makes sense :-)  

Until you find another bug :-)
> 
> >> You know if you got a patch cooked up, i'm more than happy to test !
> 
> > Hehe!
> >> 
> >> --
> >> Sander
> >> 
> 
> 

      reply	other threads:[~2014-07-14 20:25 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 20:08 [PATCH v4] PCI back fixes for 3.17 konrad
2014-07-11 20:08 ` [PATCH v4 1/5] xen-pciback: Document the various parameters and attributes in SysFS konrad
2014-07-11 20:46   ` Boris Ostrovsky
2014-07-14 16:28     ` Konrad Rzeszutek Wilk
2014-07-11 20:08 ` [PATCH v4 2/5] xen/pciback: Don't deadlock when unbinding konrad
2014-07-11 20:48   ` Boris Ostrovsky
2014-07-11 21:02     ` Konrad Rzeszutek Wilk
2014-07-14 14:13       ` Konrad Rzeszutek Wilk
2014-07-14 14:30         ` Boris Ostrovsky
2014-07-14 15:42           ` Konrad Rzeszutek Wilk
2014-07-11 20:08 ` [PATCH v4 3/5] xen/pciback: Include the domain id if removing the device whilst still in use konrad
2014-07-11 20:08 ` [PATCH v4 4/5] xen/pciback: Print out the domain owning the device konrad
2014-07-11 20:08 ` [PATCH v4 5/5] xen/pciback: Remove tons of dereferences konrad
2014-07-11 20:54   ` Boris Ostrovsky
2014-07-14 16:37 ` [Xen-devel] [PATCH v4] PCI back fixes for 3.17 Sander Eikelenboom
2014-07-14 17:22   ` Konrad Rzeszutek Wilk
2014-07-14 17:29     ` Sander Eikelenboom
2014-07-14 17:37       ` Konrad Rzeszutek Wilk
2014-07-14 17:43         ` Sander Eikelenboom
2014-07-14 17:45           ` Konrad Rzeszutek Wilk
2014-07-14 18:24             ` Sander Eikelenboom
2014-07-14 18:45               ` Konrad Rzeszutek Wilk
2014-07-14 19:01                 ` Sander Eikelenboom
2014-07-14 19:50                   ` Sander Eikelenboom
2014-07-14 19:54                   ` Konrad Rzeszutek Wilk
2014-07-14 20:16                     ` Sander Eikelenboom
2014-07-14 20:18                       ` Konrad Rzeszutek Wilk
2014-07-14 20:21                         ` Sander Eikelenboom
2014-07-14 20:25                           ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140714202531.GA24877@laptop.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@eikelenboom.it \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox