From: Dan Carpenter <dan.carpenter@oracle.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: lidza.louina@gmail.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, Mark Hounschell <markh@compro.net>
Subject: Re: [PATCH 6/8] staging: dgap: remove unneeded dgap_err()
Date: Tue, 15 Jul 2014 09:47:16 +0300 [thread overview]
Message-ID: <20140715064716.GR25880@mwanda> (raw)
In-Reply-To: <20140715030223.GA14406@devel.8.8.4.4>
On Tue, Jul 15, 2014 at 12:02:23PM +0900, Daeseok Youn wrote:
> The dgap_err() is printing a message with pr_err(),
> so all those are replaced.
>
Take a look at how pr_fmt works.
#define pr_fmt(fmt) "dgap: " fmt
Then you can remove the "dgap: " from the beginning of each line.
Also all the "out of memory" messages can be removed because the kernel
prints its own message for that.
regards,
dan carpenter
next prev parent reply other threads:[~2014-07-15 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 3:02 [PATCH 6/8] staging: dgap: remove unneeded dgap_err() Daeseok Youn
2014-07-15 6:47 ` Dan Carpenter [this message]
2014-07-15 7:25 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715064716.GR25880@mwanda \
--to=dan.carpenter@oracle.com \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox